Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mu: 0.9.18 -> 1.0 #34633

Merged
merged 1 commit into from
Mar 26, 2018
Merged

mu: 0.9.18 -> 1.0 #34633

merged 1 commit into from
Mar 26, 2018
+14 −8

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Feb 5, 2018 •
edited
Loading

Motivation for this change

I removed the tests, since one was failing during the build, but passing in nix-shell:
djcb/mu#1187
If anyone has ideas on how to troubleshoot this further, let me know.

I tried building mug as well, but the version of webkit that's passed here is marked as insecure.
When I made an exception for that in my config, mu claimed it couldn't find webkit.
Then I passed an older version, but nix started building that, so I gave up: I'm not building webkit on a 11 year old laptop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@joachifm joachifm requested a review from peterhoeg February 6, 2018 21:28
@joachifm
Copy link
Contributor

joachifm commented Feb 6, 2018

@GrahamcOfBorg build mu

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

 /nix/store/pvwc2pkr54z8bnh65lmbrz0h5m3pzn2h-coreutils-8.29/bin/install -c -m 644 NEWS.org '/nix/store/qqyzx9ak3jzy7r4kknnk8ny13zz7gi19-mu-1.0/share/doc/mu'
make[2]: Leaving directory '/private/tmp/nix-build-mu-1.0.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-mu-1.0.drv-0/source'
glibPreFixupPhase
post-installation fixup
gzipping man pages under /nix/store/qqyzx9ak3jzy7r4kknnk8ny13zz7gi19-mu-1.0/share/man/
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qqyzx9ak3jzy7r4kknnk8ny13zz7gi19-mu-1.0/bin
patching script interpreter paths in /nix/store/qqyzx9ak3jzy7r4kknnk8ny13zz7gi19-mu-1.0
/nix/store/qqyzx9ak3jzy7r4kknnk8ny13zz7gi19-mu-1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g6nbksgcsx6cimvlf1p7j9c1y1p4xdkz-mu-1.0
shrinking /nix/store/g6nbksgcsx6cimvlf1p7j9c1y1p4xdkz-mu-1.0/bin/mu
gzipping man pages under /nix/store/g6nbksgcsx6cimvlf1p7j9c1y1p4xdkz-mu-1.0/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/g6nbksgcsx6cimvlf1p7j9c1y1p4xdkz-mu-1.0/bin 
patching script interpreter paths in /nix/store/g6nbksgcsx6cimvlf1p7j9c1y1p4xdkz-mu-1.0
checking for references to /tmp/nix-build-mu-1.0.drv-0 in /nix/store/g6nbksgcsx6cimvlf1p7j9c1y1p4xdkz-mu-1.0...
/nix/store/g6nbksgcsx6cimvlf1p7j9c1y1p4xdkz-mu-1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hbygqw2d0wcbijb1dgq61bfqgfky5c18-mu-1.0
shrinking /nix/store/hbygqw2d0wcbijb1dgq61bfqgfky5c18-mu-1.0/bin/mu
gzipping man pages under /nix/store/hbygqw2d0wcbijb1dgq61bfqgfky5c18-mu-1.0/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hbygqw2d0wcbijb1dgq61bfqgfky5c18-mu-1.0/bin
patching script interpreter paths in /nix/store/hbygqw2d0wcbijb1dgq61bfqgfky5c18-mu-1.0
checking for references to /build in /nix/store/hbygqw2d0wcbijb1dgq61bfqgfky5c18-mu-1.0...
/nix/store/hbygqw2d0wcbijb1dgq61bfqgfky5c18-mu-1.0

@peterhoeg
Copy link
Member

Thanks for doing this but I would very much prefer to have the tests run. I can take a look this weekend.

@magnetophon
Copy link
Member Author

@peterhoeg Did you find time to have a look?

@peterhoeg
Copy link
Member

I didn't, sorry. :-(

@magnetophon
Copy link
Member Author

Any news on this?
Do we really need the tests?
If so, any ideas on why they pass from nix-env, yet fail during the normal build?

@magnetophon magnetophon force-pushed the mu branch 3 times, most recently from 3c58746 to 044dc20 Compare March 25, 2018 19:31
@peterhoeg
Copy link
Member

I got the tests running. Have a look at:

https://github.com/NixOS/nixpkgs/compare/master...peterhoeg:u/mu?expand=1

If you make the changes, I'll merge asap.

@magnetophon
Copy link
Member Author

@peterhoeg Thanks!
I pushed your changes.

@peterhoeg peterhoeg merged commit 81e7c18 into NixOS:master Mar 26, 2018
@peterhoeg
Copy link
Member

Thank you for your patience @magnetophon !

@magnetophon magnetophon deleted the mu branch March 26, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @joachifm @GrahamcOfBorg @peterhoeg