Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsusb for OSX #34630

Merged
merged 4 commits into from Feb 7, 2018
Merged

lsusb for OSX #34630

merged 4 commits into from Feb 7, 2018

Conversation

varunpatro
Copy link
Member

@varunpatro varunpatro commented Feb 5, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

matthewbauer
matthewbauer reviewed Feb 6, 2018
View reviewed changes
pkgs/os-specific/darwin/lsusb/default.nix
homepage = https://github.com/jlhonora/lsusb;
description = "lsusb command for Mac OS X";
platforms = stdenv.lib.platforms.darwin;
license = stdenv.lib.licenses.mit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add yourself as a maintainer here? Basically you'd just be responsible for version updates and making sure it builds.

@varunpatro
Copy link
Member Author

@matthewbauer what's the merging policy in nixpkgs? (how long on avg for PRs to get merged?) It's my first time doing this.

@LnL7
Copy link
Member

LnL7 commented Feb 7, 2018

@GrahamcOfBorg build darwin.lsusb

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Package ‘lsusb-1.0’ in /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/darwin/lsusb/default.nix:23 is not supported on ‘x86_64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘lsusb-1.0’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/os-specific/darwin/lsusb/default.nix:23 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
gzipping man pages under /nix/store/z5v2129ylhdpy7l5rrk1xpf40sp740ip-lsusb-1.0/share/man/
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/z5v2129ylhdpy7l5rrk1xpf40sp740ip-lsusb-1.0/bin
patching script interpreter paths in /nix/store/z5v2129ylhdpy7l5rrk1xpf40sp740ip-lsusb-1.0
/nix/store/z5v2129ylhdpy7l5rrk1xpf40sp740ip-lsusb-1.0/bin/lsusb: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/s8mff1kmnc63b21ybdid2ni0fw7mzy7r-bash-4.4-p12/bin/bash"
/nix/store/z5v2129ylhdpy7l5rrk1xpf40sp740ip-lsusb-1.0

@LnL7 LnL7 merged commit c0aa8f5 into NixOS:master Feb 7, 2018
@LnL7
Copy link
Member

LnL7 commented Feb 7, 2018

Thanks for contributing!

I think trivial changes usually get merged in a few days. But it also depends a lot on how many committers are familiar with the particular package, etc. The number of people actively merging darwin related changes is pretty small for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@varunpatro @LnL7 @GrahamcOfBorg @matthewbauer @Janik-Haag