Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grv: pass in version, fix "grv -version" to at least include that #34634

Merged
merged 1 commit into from Feb 7, 2018
Merged

grv: pass in version, fix "grv -version" to at least include that #34634

merged 1 commit into from Feb 7, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 5, 2018

Currently:
$ grv -version
GRV - Git Repository Viewer Unknown (commit: Unknown, compiled: Unknown)

After:
$ grv -version
GRV - Git Repository Viewer 0.1.1 (commit: Unknown, compiled: Unknown)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
grv: pass in version, fix "grv -version" to at least include that
9ee6f46 
Currently:
$ grv -version
GRV - Git Repository Viewer Unknown (commit: Unknown, compiled: Unknown)

After:
$ grv -version
GRV - Git Repository Viewer 0.1.1 (commit: Unknown, compiled: Unknown)
@dtzWill dtzWill mentioned this pull request Feb 7, 2018
Merged
8 tasks
@andir
Copy link
Member

andir commented Feb 7, 2018

looks good to me! Thanks again @dtzWill 👍

@andir andir merged commit dc89752 into NixOS:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @andir @GrahamcOfBorg