release-common: use shell from nixpkgs, provide fallback for compat #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may want to change the attribute name to something less busybox-centric, leaving open use of dash or static bash or something. |
|
Looks good to me. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat of an alternative to #1842.
Instead of maintaining two definitions of "basic static shell sufficient to be used as /bin/sh"
(which may change moving forward across nixpkgs versions)
have the nixpkgs we're building against define what this means and use that by default.
As a fallback provide our own definition, which this PR leaves alone but we may want to one-time
update to include the changes in #1842 .
Hopefully this avoids having to update this in two places, as well as somewhat making things slightly
forward-compatible should nixpkgs change what we use for our basic shell.
This relies on https://github.com/dtzWill/nixpkgs/tree/feature/busybox-sandbox-shell which I haven't issued a PR for yet.
Does this seem like an improvement / good way to go?