Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-9_x: update version to 9.5.0 #34632

Closed
wants to merge 1 commit into from
Closed

nodejs-9_x: update version to 9.5.0 #34632

wants to merge 1 commit into from

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Feb 5, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pbogdan
Copy link
Member

pbogdan commented Feb 5, 2018

FYI seems like there is an update to 9.5.0 comited to staging - 1177bb7

@periklis
Copy link
Contributor Author

periklis commented Feb 5, 2018

Oh really, that's the last place i forgot to check out. Sorry, we can dismiss this PR then :)

@periklis periklis closed this Feb 5, 2018
@periklis periklis deleted the update-nodejs-9_x branch February 5, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@periklis @pbogdan @GrahamcOfBorg