Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.react-native-cli: init at 2.0.1 #34097

Merged
merged 1 commit into from Jan 21, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 21, 2018

Motivation for this change

react-native-cli is a helpful CLI tool to build/run react-native applications.

  • regenerated package set
  • added react-native
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member Author

Ma27 commented Jan 21, 2018

ouch, my own nixpkgs was obviously way too old, will do a rebase now :)

@Ma27
Copy link
Member Author

Ma27 commented Jan 21, 2018

ok, looks good now...

@Ma27
Copy link
Member Author

Ma27 commented Jan 21, 2018

currently running nox-review against this PR :)

@Ma27
Copy link
Member Author

Ma27 commented Jan 21, 2018

The output of nox-review pr 34097:

lrwxrwxrwx 1 ma27 users 70 Jan 21 12:00 result -> /nix/store/r9yg81731v75va9fsnklrs9i7858id3q-python3.6-jupyterhub-0.8.1
lrwxrwxrwx 1 ma27 users 61 Jan 21 12:00 result-10 -> /nix/store/c82sin7kq6nkbqczb3wh31bqgvnksc40-node-statsd-0.8.0
lrwxrwxrwx 1 ma27 users 56 Jan 21 12:00 result-11 -> /nix/store/0nqjalw62hbw4a7xsa5mdjzbvqxchdi0-emojione-1.3
lrwxrwxrwx 1 ma27 users 63 Jan 21 12:00 result-2 -> /nix/store/ibni7iq1wpm9fjkjdc0900pf4y31v2cv-node-fast-cli-1.0.0
lrwxrwxrwx 1 ma27 users 58 Jan 21 12:00 result-3 -> /nix/store/b4q82p1l9hczs82ycy811cj0pjzh0g7f-uchiwa-1.1.1-1
lrwxrwxrwx 1 ma27 users 60 Jan 21 12:00 result-4 -> /nix/store/hyvn8jdyn40d3zrmd2a35hqivj8qk46w-node-wring-1.0.0
lrwxrwxrwx 1 ma27 users 72 Jan 21 12:00 result-5 -> /nix/store/ikr5326ihqj0px6k97psq3z54n31mqzi-node-quassel-webserver-2.2.8
lrwxrwxrwx 1 ma27 users 66 Jan 21 12:00 result-6 -> /nix/store/0fry7q3znidzawkybbdba57p8chdpsji-node-azure-cli-0.10.17
lrwxrwxrwx 1 ma27 users 59 Jan 21 12:00 result-7 -> /nix/store/sca2344ipsffg06hz4zzm23arg0svgch-node-sloc-0.2.0
lrwxrwxrwx 1 ma27 users 61 Jan 21 12:00 result-8 -> /nix/store/bjszn9x3780z3m2qwnblz23xbim3hs7j-node-shout-0.53.0
lrwxrwxrwx 1 ma27 users 63 Jan 21 12:00 result-9 -> /nix/store/p1lgcqflzc8h4l0vfp97h4zxk7qin40h-node-npm2nix-5.12.0

@Mic92 Mic92 merged commit cf93bcb into NixOS:master Jan 21, 2018
@Ma27 Ma27 deleted the init-react-native branch January 21, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants