Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: Configure aarch64 toolchain #34105

Merged
merged 1 commit into from Jan 21, 2018
Merged

chromium: Configure aarch64 toolchain #34105

merged 1 commit into from Jan 21, 2018

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Running chromium on aarch64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (aarch64 only)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

So far as I can tell, there's nothing about the build process for chromium that doesn't work on aarch64, except for the toolchain configuration. Removing the prefix makes it build and run.

After building this I noticed the following, which probably isn't having any effect.

      # use our own nodejs
      mkdir -p third_party/node/linux/node-linux-x64/bin
      ln -s $(which node) third_party/node/linux/node-linux-x64/bin/node

It took a number of days for this build, (admittedly with two cores idle, which is the default for this package). I don't know how viable it is to iterate on this, so I'm presenting it in its current state. Having the package build and run is better than not building at all, even if it's not perfect.

@dezgeg
Copy link
Contributor

dezgeg commented Jan 21, 2018

Yeah, I checked some time back that Arch Linux ARM applies a similar patch to Chromium but for some reason their patch didn't work for us. So this approach should be perfectly fine. Let me build-test this.

@dezgeg
Copy link
Contributor

dezgeg commented Jan 21, 2018

Thanks for your efforts on aarch64. If you'd like to experiment on a faster aarch64 box, (as in, one that builds chromium in ~6.5 hours), see https://github.com/nix-community/aarch64-build-box and the #nixos-aarch64 channel on FreeNode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants