SDL2_{gfx,mixer,net,ttf}: fix Darwin build #34089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build SDL2_gfx SDL2_mixer SDL2_net SDL2_ttf |
There was a problem hiding this comment.
Success for system: x86_64-linux
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 13696 100 13696 0 0 13696 0 0:00:01 --:--:-- 0:00:01 76088
100 63272 100 63272 0 0 63272 0 0:00:01 --:--:-- 0:00:01 566k
/nix/store/pfinsmw3pd0cpd9h7g0g994n9jbrxbr8-SDL2_gfx-1.0.1
/nix/store/gc7xjyi5z5fi7a80if5myzv1gqb4jr32-SDL2_mixer-2.0.2
/nix/store/81yjh9hhcksj32rv0hljan55sczcag6w-SDL2_net-2.0.1
/nix/store/qxl0smqzvchn870gk5s122ak08waqa2c-SDL2_ttf-2.0.14
There was a problem hiding this comment.
Success for system: aarch64-linux
copying path '/nix/store/am2jlyi40299w38k5iy0dlw7b1plvx5d-SDL2-2.0.7-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/qkq67g4xmq56b2gnhb6sy943s08zf1b6-SDL2_gfx-1.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/wwa18pwxr962j47687q6m4x1s9rpv4py-SDL2_ttf-2.0.14' from 'https://cache.nixos.org'...
copying path '/nix/store/6cwsn2j4jqpk6als73rx7g6a75ynkcbm-SDL2_net-2.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/1x2jb5zfhwdic20x7g1xmnq5b2k6y7hq-smpeg2-svn412' from 'https://cache.nixos.org'...
copying path '/nix/store/xbpps45zmhr9xcs9q11s8wrnw62x0wb4-SDL2_mixer-2.0.2' from 'https://cache.nixos.org'...
/nix/store/qkq67g4xmq56b2gnhb6sy943s08zf1b6-SDL2_gfx-1.0.1
/nix/store/xbpps45zmhr9xcs9q11s8wrnw62x0wb4-SDL2_mixer-2.0.2
/nix/store/6cwsn2j4jqpk6als73rx7g6a75ynkcbm-SDL2_net-2.0.1
/nix/store/wwa18pwxr962j47687q6m4x1s9rpv4py-SDL2_ttf-2.0.14
jtojnar
reviewed
Jan 20, 2018
| @@ -9,6 +9,8 @@ stdenv.mkDerivation rec { | |||
| sha256 = "16jrijzdp095qf416zvj9gs2fqqn6zkyvlxs5xqybd0ip37cp6yn"; | |||
| }; | |||
|
|
|||
| nativeBuildInputs = stdenv.lib.optional stdenv.isDarwin darwin.libobjc; | |||
There was a problem hiding this comment.
Are you sure this should be in nativeBuildInputs?
There was a problem hiding this comment.
My bad. Probably libobjc should be in buildInputs.
LnL7
approved these changes
Jan 20, 2018
There was a problem hiding this comment.
Success for system: x86_64-darwin
/nix/store/977jc5nd9cd22rdly4d990zb4hhdb6fs-SDL2_mixer-2.0.2/lib/libSDL2_mixer-2.0.0.dylib: fixing dylib
/nix/store/977jc5nd9cd22rdly4d990zb4hhdb6fs-SDL2_mixer-2.0.2/lib/libSDL2_mixer-2.0.0.dylib: fixing dylib
/nix/store/977jc5nd9cd22rdly4d990zb4hhdb6fs-SDL2_mixer-2.0.2/lib/libSDL2_mixer-2.0.0.dylib: fixing dylib
/nix/store/977jc5nd9cd22rdly4d990zb4hhdb6fs-SDL2_mixer-2.0.2/lib/libSDL2_mixer-2.0.0.dylib: fixing dylib
/nix/store/977jc5nd9cd22rdly4d990zb4hhdb6fs-SDL2_mixer-2.0.2/lib/libSDL2_mixer-2.0.0.dylib: fixing dylib
/nix/store/977jc5nd9cd22rdly4d990zb4hhdb6fs-SDL2_mixer-2.0.2/lib/libSDL2_mixer-2.0.0.dylib: fixing dylib
/nix/store/2vkncg59bcwi3mamam4lf5qxflvh2igj-SDL2_gfx-1.0.1
/nix/store/977jc5nd9cd22rdly4d990zb4hhdb6fs-SDL2_mixer-2.0.2
/nix/store/yj751s98kg7bb2m68n0cjryps4ch1whs-SDL2_net-2.0.1
/nix/store/a8vfflnhlmi08w0p2ch5nl1hpfjfxbdq-SDL2_ttf-2.0.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Hopefully this fixes 89c8671.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)