Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrain-editors: 2017.3.2 -> 2017.3.3 #34102

Merged
merged 9 commits into from Jan 22, 2018
Merged

jetbrain-editors: 2017.3.2 -> 2017.3.3 #34102

merged 9 commits into from Jan 22, 2018

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Jan 21, 2018

Motivation for this change

New minor releases, I am only using IDEA, though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jokogr jokogr requested a review from edwtjo as a code owner January 21, 2018 13:03
@Mic92
Copy link
Member

Mic92 commented Jan 21, 2018 •
edited

Can you make one commit per package? I need to backport some of these updates.

@jokogr jokogr force-pushed the u/jetbrains-editors-2017.3.3 branch from 7b7130c to 9bd6b32 Compare January 22, 2018 09:42
@jokogr
Copy link
Contributor Author

jokogr commented Jan 22, 2018

@Mic92 sure thing, there you go

@Mic92 Mic92 merged commit 77d8436 into NixOS:master Jan 22, 2018
@jokogr jokogr deleted the u/jetbrains-editors-2017.3.3 branch February 22, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jokogr @Mic92 @GrahamcOfBorg