Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-info: build locally #34103

Merged
merged 1 commit into from Jan 21, 2018
Merged

nix-info: build locally #34103

merged 1 commit into from Jan 21, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 21, 2018

Motivation for this change

/cc @grahamc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jan 21, 2018

Hmm... why?

@LnL7
Copy link
Member Author

LnL7 commented Jan 21, 2018

Copying a file locally is faster then copying everything back and forth with build-remote.

@grahamc
Copy link
Member

grahamc commented Jan 21, 2018

Ah makes sense. This won't make any impact on users fetching it from the cache though, right?

@LnL7
Copy link
Member Author

LnL7 commented Jan 21, 2018

No, that would be allowSubstitutes = false;.

@grahamc
Copy link
Member

grahamc commented Jan 21, 2018

👍

@vcunat vcunat merged commit aa32796 into NixOS:master Jan 21, 2018
vcunat added a commit that referenced this pull request Jan 21, 2018
@vcunat
Merge #34103: nix-info: build locally
59fb55c
@LnL7 LnL7 deleted the nix-info branch January 21, 2018 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LnL7 @grahamc @vcunat @GrahamcOfBorg