Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcbuild: platform version #34088

Merged
merged 2 commits into from Jan 21, 2018
Merged

xcbuild: platform version #34088

merged 2 commits into from Jan 21, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 20, 2018

Motivation for this change

Without this xcbuild can detect an incorrect version for store paths
that have a sequence of digits in their hash. See https://hydra.nixos.org/build/67632952.

ld: malformed 32-bit x.y.z version number: 85294
/nix/store/yz966rdvw1blblvzs15pxpcd85294isw-MacOSX.platform/Developer/SDKs/MacOSX.sdk

/cc @copumpkin @matthewbauer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Without this xcbuild can detect an incorrect version for store paths
that have a sequence of digits in their hash.

ld: malformed 32-bit x.y.z version number: 85294

/nix/store/yz966rdvw1blblvzs15pxpcd85294isw-MacOSX.platform/Developer/SDKs/MacOSX.sdk
@LnL7 LnL7 added 6.topic: darwin Running or building packages on Darwin 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 20, 2018
@matthewbauer
Copy link
Member

Lgtm

@grahamc
Copy link
Member

grahamc commented Jan 21, 2018

@GrahamcOfBorg build xcbuild

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

building '/nix/store/wiv8kf5cxs61fzzcrlwxyjw2661c1f5d-MacOSX10.10.sdk.drv'...
copying path '/nix/store/1v0bkq8l6nkpgj4znilvrav27pk3ha7q-nixpkgs.xctoolchain' from 'https://cache.nixos.org'...
building '/nix/store/gr5g6j3hlzrqny8dkaibz01pdqix8bbq-MacOSX.platform.drv'...
building '/nix/store/3nsbyb7mii2p49x2yixwz4mqg8ppnxzr-xcbuild-wrapper-0.1.2-pre.drv'...
installing
post-installation fixup
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/a96ipc80y5c2m3f56f7jccyfdyf858cq-xcbuild-wrapper-0.1.2-pre/bin
patching script interpreter paths in /nix/store/a96ipc80y5c2m3f56f7jccyfdyf858cq-xcbuild-wrapper-0.1.2-pre
/nix/store/a96ipc80y5c2m3f56f7jccyfdyf858cq-xcbuild-wrapper-0.1.2-pre

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux


building path(s) ‘/nix/store/192smwqr46q5h1pxc5jnalz4lyr9b6c3-xcbuild-wrapper-0.1.2-pre’
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/192smwqr46q5h1pxc5jnalz4lyr9b6c3-xcbuild-wrapper-0.1.2-pre
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/192smwqr46q5h1pxc5jnalz4lyr9b6c3-xcbuild-wrapper-0.1.2-pre/bin 
patching script interpreter paths in /nix/store/192smwqr46q5h1pxc5jnalz4lyr9b6c3-xcbuild-wrapper-0.1.2-pre
checking for references to /tmp/nix-build-xcbuild-wrapper-0.1.2-pre.drv-0 in /nix/store/192smwqr46q5h1pxc5jnalz4lyr9b6c3-xcbuild-wrapper-0.1.2-pre...
/nix/store/192smwqr46q5h1pxc5jnalz4lyr9b6c3-xcbuild-wrapper-0.1.2-pre

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

copying path '/nix/store/kd1d7b7jhlc015fsjw9s0frhia3ybmcl-stdenv' from 'https://cache.nixos.org'...
building '/nix/store/s7mml3m80mwafmyrznvkaxcgqmlhmj89-xcbuild-wrapper-0.1.2-pre.drv'...
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/76bck6yqg8sk53aw8vybax9w94nwsl4a-xcbuild-wrapper-0.1.2-pre
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/76bck6yqg8sk53aw8vybax9w94nwsl4a-xcbuild-wrapper-0.1.2-pre/bin
patching script interpreter paths in /nix/store/76bck6yqg8sk53aw8vybax9w94nwsl4a-xcbuild-wrapper-0.1.2-pre
checking for references to /build in /nix/store/76bck6yqg8sk53aw8vybax9w94nwsl4a-xcbuild-wrapper-0.1.2-pre...
/nix/store/76bck6yqg8sk53aw8vybax9w94nwsl4a-xcbuild-wrapper-0.1.2-pre

@LnL7
Copy link
Member Author

LnL7 commented Jan 21, 2018

@GrahamcOfBorg build pinentry_mac

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

Package ‘pinentry-mac-0.9.4’ in /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/pkgs/tools/security/pinentry-mac/default.nix:27 is not supported on ‘x86_64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘pinentry-mac-0.9.4’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/tools/security/pinentry-mac/default.nix:27 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

/nix/store/vrwap9xrxcrpllm40ska759kikb8zidq-pinentry-mac-0.9.4

@LnL7 LnL7 merged commit 82de183 into NixOS:master Jan 21, 2018
@LnL7 LnL7 deleted the xcbuild-platform-version branch January 21, 2018 19:50
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants