Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcWithPackages: Misc cleanups #33433

Merged
merged 3 commits into from Jan 5, 2018
Merged

ghcWithPackages: Misc cleanups #33433

merged 3 commits into from Jan 5, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Remove unneeded stuff and fix link in comment

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
ghcWithPackages: Don't bother with ignoreCollisions cause we don't us…
6bdf9a7 
…e buildEnv

SymlinkJoin doesn't know or care about this.
@Ericson2314 Ericson2314 requested a review from peti as a code owner January 4, 2018 19:31
@Ericson2314
ghcWithPackages: Get rid of unused passthrough
dea9fce 
If you want the whole packages set...don't use ghcWithPackages.
@Ericson2314
ghcWithPackages: Fix comment URL
ec2f121
@peti peti merged commit be49066 into NixOS:master Jan 5, 2018
@Ericson2314
Copy link
Member Author

Thanks!

@Ericson2314 Ericson2314 deleted the haskell-misc branch January 5, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@cstrahan cstrahan Awaiting requested review from cstrahan

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @peti @GrahamcOfBorg