Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopkgs: init at 2017-12-29 #33430

Merged
merged 1 commit into from
Feb 14, 2018
Merged

gopkgs: init at 2017-12-29 #33430

merged 1 commit into from
Feb 14, 2018
+37 −0

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jan 4, 2018 •
edited
Loading

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

gopkgs is a tool to get list available Go packages. Mainly used by vscode and other editor with go support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@vdemeester vdemeester changed the title gopkgs: init at 20171229-b2ea2ec gopkgs: init at 2017-12-29 Jan 19, 2018
nlewo
nlewo requested changes Feb 13, 2018
View reviewed changes
pkgs/development/tools/gopkgs/default.nix Outdated
goPackagePath = "github.com/uudashr/gopkgs";
goDeps = ./deps.nix;

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use fetchFromGitHub?

@vdemeester
gopkgs: init at 2017-12-29
8cf5684 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Member Author

@nlewo updated 😉

@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Feb 14, 2018
@nlewo
Copy link
Member

nlewo commented Feb 14, 2018

@GrahamcOfBorg build gopkgs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vj5drrvkcl01vxrqr8b0shkzzxgyjljd-gopkgs-unstable-2017-12-29-bin/bin 
patching script interpreter paths in /nix/store/vj5drrvkcl01vxrqr8b0shkzzxgyjljd-gopkgs-unstable-2017-12-29-bin
checking for references to /tmp/nix-build-gopkgs-unstable-2017-12-29.drv-0 in /nix/store/vj5drrvkcl01vxrqr8b0shkzzxgyjljd-gopkgs-unstable-2017-12-29-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/8b02pa18a8kpiv3nbwiwgrpx0sg7x84l-gopkgs-unstable-2017-12-29
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/8b02pa18a8kpiv3nbwiwgrpx0sg7x84l-gopkgs-unstable-2017-12-29
checking for references to /tmp/nix-build-gopkgs-unstable-2017-12-29.drv-0 in /nix/store/8b02pa18a8kpiv3nbwiwgrpx0sg7x84l-gopkgs-unstable-2017-12-29...
/nix/store/vj5drrvkcl01vxrqr8b0shkzzxgyjljd-gopkgs-unstable-2017-12-29-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/w0w1d515ijhszirkhq4z3fc4ajj0rynz-gopkgs-unstable-2017-12-29-bin/bin
patching script interpreter paths in /nix/store/w0w1d515ijhszirkhq4z3fc4ajj0rynz-gopkgs-unstable-2017-12-29-bin
checking for references to /build in /nix/store/w0w1d515ijhszirkhq4z3fc4ajj0rynz-gopkgs-unstable-2017-12-29-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/8lyzlqbbjn10v9wcgy4i3kry62yaavr1-gopkgs-unstable-2017-12-29
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/8lyzlqbbjn10v9wcgy4i3kry62yaavr1-gopkgs-unstable-2017-12-29
checking for references to /build in /nix/store/8lyzlqbbjn10v9wcgy4i3kry62yaavr1-gopkgs-unstable-2017-12-29...
/nix/store/w0w1d515ijhszirkhq4z3fc4ajj0rynz-gopkgs-unstable-2017-12-29-bin

@nlewo nlewo merged commit c385a1b into NixOS:master Feb 14, 2018
@nlewo
Copy link
Member

nlewo commented Feb 14, 2018

Thanks

@vdemeester vdemeester deleted the init-gopkgs branch February 14, 2018 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @nlewo @GrahamcOfBorg