Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change definitions from use of luminance to use of luma #97

Closed
wants to merge 1 commit into from
Closed

change definitions from use of luminance to use of luma #97

wants to merge 1 commit into from

Conversation

ablwr
Copy link
Contributor

@ablwr ablwr commented Jan 4, 2018

As raised in #92, uses luma in definitions instead of luminance

@JeromeMartinez
Copy link
Contributor

I thought it would be more complicated.
Wondering it there are other places with similar issue about luma/chroma wording, ping @retokromer .

@ablwr
Copy link
Contributor Author

ablwr commented Jan 4, 2018

Everywhere else uses luma!

@dericed
Copy link
Contributor

dericed commented Jan 9, 2018

nudging for either more reviews or a merge on this and the others. I'd like to get an active ffv1 draft back in the cellar tracker.

retokromer
retokromer approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@retokromer retokromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, this can be merged. And another PR may fix the remaining incongruencies.

@michaelni michaelni closed this in 141cf81 Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dericed dericed dericed approved these changes

@retokromer retokromer retokromer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ablwr @JeromeMartinez @dericed @retokromer