Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ssh keys retrieval in GCE instances #33423

Merged
merged 1 commit into from Jan 18, 2018
Merged

Fix ssh keys retrieval in GCE instances #33423

merged 1 commit into from Jan 18, 2018

Conversation

AmineChikhaoui
Copy link
Member

Seems the google compute metadata service behavior changed a bit
recently which caused this issue ?
see: https://cloud.google.com/compute/docs/storing-retrieving-metadata

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@AmineChikhaoui
Fixes NixOS/nixops#756.
5dba59d 
Seems the google compute metadata service behavior changed a bit
recently which caused this issue ?
see: https://cloud.google.com/compute/docs/storing-retrieving-metadata
@AmineChikhaoui AmineChikhaoui changed the title Fixe ssh keys retrieval in GCE instances Fix ssh keys retrieval in GCE instances Jan 4, 2018
@rbvermaa rbvermaa merged commit 38538f3 into NixOS:master Jan 18, 2018
@AmineChikhaoui
Copy link
Member Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AmineChikhaoui @rbvermaa @GrahamcOfBorg