Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-symbols: init at 2017-02-06 #33427

Merged
merged 1 commit into from Feb 10, 2018
Merged

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jan 4, 2018

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

go-symbols is an utility for extracting a JSON representation of the package symbols from a go source tree. It's used in vscode and other editors 馃懠

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Jan 5, 2018

It seems to me the nixpkgs convention for the name of a package that doesn't have any version is package-name-YY-MM-DD. But I cannot find any spec about this convention:/
Some information on this?

@nlewo
Copy link
Member

nlewo commented Jan 5, 2018

In fact, it is mentionnend here: https://nixos.org/nixpkgs/manual/#sec-package-naming

And the format is YYYY-MM-DD

@vdemeester
Copy link
Member Author

@nlewo hum.. there is a few package that uses YYYMMDD-{commitid} though.. Happy to change this new one for sure 馃懠

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Member Author

@nlewo updated 馃懠

@vdemeester vdemeester changed the title go-symbols: init at 20170206-5a7f759 go-symbols: init at 2017-02-06 Jan 19, 2018
@nlewo
Copy link
Member

nlewo commented Feb 9, 2018

@Mic92 LGTM. Could you have a lool?

@Mic92 Mic92 merged commit 7fd8e8b into NixOS:master Feb 10, 2018
@vdemeester vdemeester deleted the init-go-symbols branch February 10, 2018 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants