Workaround llvm.powi.* intrinsics not available on win32 #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
Jan 4, 2018
|
@RX14 wouldn't be better move the platform condition down to Apologies if this was discussed elsewhere. Thank you. |
|
@luislavena I'm not sure what you mean... |
|
Apologies for the brevity of previous message. I was thinking something similar to the approach taken in #5533 and reduce the number of places platform condition needs to be checked to only Cheers. |
|
@luislavena no, I did that because creating an entirely new function is the only way to create a new va_list. |
|
Thanks for the clarification. Was simply a thought. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.