Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: 3.9.6 -> 3.10.0 #33435

Closed
wants to merge 2 commits into from
Closed

cmake: 3.9.6 -> 3.10.0 #33435

wants to merge 2 commits into from

Conversation

robertodr
Copy link
Contributor

Motivation for this change

Update CMake to 3.10.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Jan 5, 2018

It would be cool to have the manpage as it's quite helpful. I had started sthg but had to stop working on it #31344

@@ -38,7 +38,7 @@ stdenv.mkDerivation rec {
'';

# Don't search in non-Nix locations such as /usr, but do search in our libc.
patches = [ ./search-path-3.9.patch ]
patches = [ ./search-path-3.10.patch ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to rename or change the patch.

vcunat added a commit to vcunat/nixpkgs that referenced this pull request Jan 21, 2018
@vcunat
Copy link
Member

vcunat commented Jan 22, 2018

Staged cmake-3.10.2.

@vcunat vcunat closed this Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants