Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 0f925943fdea
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: f29ecd56c1b6
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Jan 3, 2018

  1. nixos/memcached: make unix sockets usuable

    before:
      - /var/run/memcached is a bad default for a socket path, since its
        parent directory must be writeable by memcached.
      - Socket directory was not created by the module itself -> this was
        left as a burden to the user?
      - Having a static uid with a dynamic user name is not very useful.
    
    after:
      - Replace services.memcached.socket by a boolean flag. This simplifies
        our code, since we do not have to check if the user specifies a
        path with a parent directory that should be owned by memcached
        (/run/memcached/memcached.sock -> /run/memcached).
      - Remove fixed uid/gid allocation. The only file ever owned by the
        daemon is the socket that will be recreated on every start.
        Therefore user and group ids do not need to be static.
      - only create the memcached user, if the user has not specified a
        different one. The major use case for changing option is to allow
        existing services (such as php-fpm) opening the local unix socket.
        If we would unconditionally create a user that option would be
        useless.
    Mic92 committed Jan 3, 2018
    Copy the full SHA
    c9c8a2c View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2018

  1. Merge pull request #33372 from Mic92/memcache

    nixos/memcached: make unix sockets usuable
    Mic92 committed Jan 4, 2018
    Copy the full SHA
    f29ecd5 View commit details
    Browse the repository at this point in the history