Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-protobuf: init at 2018-01-04 #33426

Merged
merged 1 commit into from Jan 16, 2018
Merged

go-protobuf: init at 2018-01-04 #33426

merged 1 commit into from Jan 16, 2018

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Jan 4, 2018

With the commit 1e59b77b52bf8e4b449a57e6f79f21226d571845

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

With the commit 1e59b77b52bf8e4b449a57e6f79f21226d571845
@nlewo
Copy link
Member Author

nlewo commented Jan 15, 2018

@Mic92 could you have a look please?

I don't know who could I ping to review/merge Go packages.

@Mic92 Mic92 merged commit c53f151 into NixOS:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants