Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-outline: init at 2017-08-04 #33428

Merged
merged 1 commit into from Feb 14, 2018
Merged

go-outline: init at 2017-08-04 #33428

merged 1 commit into from Feb 14, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jan 4, 2018 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

go-outline is an utility to extract JSON representation of declarations from a Go source file. Mainly used by vsdcode and other editor (with go support).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vdemeester vdemeester changed the title go-outline: init at 20170804-9e9d089 go-outline: init at 2017-08-04 Jan 19, 2018
nlewo
nlewo requested changes Feb 13, 2018
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also rebase it?
Otherwise, LGTM

pkgs/development/tools/go-outline/default.nix Outdated
goPackagePath = "github.com/ramya-rao-a/go-outline";
goDeps = ./deps.nix;

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use fetchFromGitHub?
https://nixos.org/nixpkgs/manual/#sec-sources

@vdemeester
go-outline: init at 2017-08-04
5c410b9 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Member Author

@nlewo updated 😉

@nlewo
Copy link
Member

nlewo commented Feb 14, 2018

@GrahamcOfBorg build go-outline

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hqr47kfl1dxr4bpj1c71ldgfn6ga6335-go-outline-unstable-2017-08-04-bin/bin
patching script interpreter paths in /nix/store/hqr47kfl1dxr4bpj1c71ldgfn6ga6335-go-outline-unstable-2017-08-04-bin
checking for references to /build in /nix/store/hqr47kfl1dxr4bpj1c71ldgfn6ga6335-go-outline-unstable-2017-08-04-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/023zay2ic3xxcy7wg0j45wppiw743lbh-go-outline-unstable-2017-08-04
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/023zay2ic3xxcy7wg0j45wppiw743lbh-go-outline-unstable-2017-08-04
checking for references to /build in /nix/store/023zay2ic3xxcy7wg0j45wppiw743lbh-go-outline-unstable-2017-08-04...
/nix/store/hqr47kfl1dxr4bpj1c71ldgfn6ga6335-go-outline-unstable-2017-08-04-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9f4crcdlh98dh0cr6nzk726dyi8nwds4-go-outline-unstable-2017-08-04-bin/bin
patching script interpreter paths in /nix/store/9f4crcdlh98dh0cr6nzk726dyi8nwds4-go-outline-unstable-2017-08-04-bin
checking for references to /build in /nix/store/9f4crcdlh98dh0cr6nzk726dyi8nwds4-go-outline-unstable-2017-08-04-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/wvpjnh7ymlx0qdigzwsrqlj0g8pk3v36-go-outline-unstable-2017-08-04
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/wvpjnh7ymlx0qdigzwsrqlj0g8pk3v36-go-outline-unstable-2017-08-04
checking for references to /build in /nix/store/wvpjnh7ymlx0qdigzwsrqlj0g8pk3v36-go-outline-unstable-2017-08-04...
/nix/store/9f4crcdlh98dh0cr6nzk726dyi8nwds4-go-outline-unstable-2017-08-04-bin

@nlewo nlewo merged commit 71f1296 into NixOS:master Feb 14, 2018
@nlewo
Copy link
Member

nlewo commented Feb 14, 2018

Thanks

@vdemeester vdemeester deleted the init-go-outline branch February 14, 2018 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @nlewo @GrahamcOfBorg