openvpn: make systemd dependency optional #33383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This option is most commonly named |
systemd is a fairly large dependency, and it doesn't appear to be necessary in all circumstances - e.g. when openvpn is not run as a systemd service (as is usually the case when it is run in a Docker container). This change makes the dependency on systemd optional, controlled by a new argument `useSystemd`. The default behaviour remains the same as it was before this change: enabled only on Linux systems. For me, this change reduces the size of my container image (dominated by the closure of openvpn) from about 110 MB to 45 MB. Version 2: rename argument to `useSystemd` (was `systemdSupport`), and rebase onto master
kierdavis
force-pushed
the
openvpn-optional-systemd
branch
from
35636fa
to
397daef
Compare
|
Thanks, renamed it. |
|
cc package maintainer @viric |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd is a fairly large dependency, and it doesn't appear to
be necessary in all circumstances - e.g. when openvpn is
not run as a systemd service (as is usually the case when it is
run in a Docker container).
This change makes the dependency on systemd optional, controlled
by a new argument
systemdSupport. The default behaviour remainsthe same as it was before this change: enabled only on Linux systems.
For me, this change reduces the size of my container image (dominated
by the closure of openvpn) from about 110 MB to 45 MB.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)