Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fonttools: 3.21.0 -> 3.21.1 #33384

Merged
merged 1 commit into from Jan 4, 2018
Merged

fonttools: 3.21.0 -> 3.21.1 #33384

merged 1 commit into from Jan 4, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jan 3, 2018 •
edited

Motivation for this change

Building fonttools currently fails since the releases do not contain all files required for running the tests. I filed a PR with the upstream repository to add the missing line to MANIFEST.in [1].

This can be reverted with the next fonttools release that contains the fix.

The PR has been merged. I've updated this PR to be a simple version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir andir requested a review from FRidh as a code owner January 3, 2018 18:28
@anthrotype
Copy link

FYI I just released fonttools 3.21.1 containing the bugfix from @andir.

https://github.com/fonttools/fonttools/releases/tag/3.21.1
https://pypi.python.org/pypi/FontTools/3.21.1

Thanks!

@andir andir changed the title fonttools: fixed checkPhase, new test asset was missing from MANIFEST.in fonttools: 3.21.0 -> 3.21.1 Jan 3, 2018
@andir
Copy link
Member Author

andir commented Jan 3, 2018

Updated the PR to be a simple version bump (3.21.0 -> 3.21.1)

@adisbladis adisbladis merged commit 0009c81 into NixOS:master Jan 4, 2018
@andir andir deleted the add-fonttools-test-asset branch January 4, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @anthrotype @adisbladis @GrahamcOfBorg