Correct boost configure phase when enablePython is false #33393
Conversation
|
Oops, this is my bad. It was like that before Do you think you can keep the order the same to avoid a mass rebuild? Also could you rebase on https://github.com/obsidiansystems/nixpkgs/tree/ericson2314-cross-base (trying to be defensive about pulling commits from master, but maybe this isn't needed post-@GrahamcOfBorg) |
bnikolic
force-pushed
the
boostconfigurepythonfix
branch
from
2c0e153
to
4dafc59
Compare
|
Rebased and corrected. PR is still showing against Nixos master, not sure how to switch it to your branch @Ericson2314 |
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 501+
labels
The bootstrap script does not seem to have --without-python; instead just omit --with-python option
Ericson2314
force-pushed
the
boostconfigurepythonfix
branch
from
4dafc59
to
35462db
Compare
|
@bnikolic that's because the rebase duplicated a bunch of commits from master that were previously on your branch but not mine. In the future, you can use |
| (if enablePython then "--with-python=${python.interpreter}" else "--without-python") | ||
| (if hostPlatform == buildPlatform then "--with-icu=${icu.dev}" else "--without-icu") | ||
| ] ++ optional (toolset != null) "--with-toolset=${toolset}"; | ||
| ] ++ optional enablePython "--with-python=${python.interpreter}" |
There was a problem hiding this comment.
Also n.b. the ] ++, despite the weird indent, is somewhat idiomatic.
The bootstrap script does not seem to have --without-python; instead
just omit --with-python option
Motivation for this change
configurationPhase currently fails when enablePython is false (e.g., when cross-compiling this is the default).
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)