Remove bin/crystal usage for init tool specs
#5520
Merged
+36
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid passing |
bew
force-pushed
the
spec-init-programatically
branch
from
e750686 to
2b48076
Compare
|
@asterite the specs fails weirdly because there are early exits in the init tool, so when the spec check a specific error, it exits after printing a little msg on stderr. (no idea how I got the specs to pass once on my computer...) I'm going in another way, using exceptions instead of |
RX14
approved these changes
Jan 4, 2018
|
circleci seems to be flakey downloading things from homebrew, i've had to restart a number of builds. |
asterite
requested changes
Jan 4, 2018
|
@asterite I kept |
asterite
approved these changes
Jan 5, 2018
RX14
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels ugly to pass
stderrall over the place, but hey.. it works!I think that the routines getting the correct fields from the given args being in the class is not correct, we should probably build a intermediate object (kind of factory which takes arguments and 'parse' them) that will create & return the
InitProjectobject then execute it or sth like that.. Absolutely not sure about this..Maybe we should just merge this to remove
bin/crystaldirect usage, and make another PR to refactor the init tool? (I think I would prefer that)WDYT?