GHC: Normalize derivations is a few simple-hash preserving ways #33399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
commented
Jan 3, 2018
| @@ -9,7 +9,7 @@ stdenv.mkDerivation rec { | |||
| name = "ghc-${version}"; | |||
|
|
|||
| src = fetchurl { | |||
| url = "${meta.homepage}/dist/${version}/${name}-src.tar.bz2"; | |||
| url = "https://downloads.haskell.org/~ghc/${version}/ghc-${version}-src.tar.bz2"; | |||
There was a problem hiding this comment.
${name} is a bad shorthand because the name is prefixed for cross compilers.
There was a problem hiding this comment.
Longterm: don't suffix (I believe it's suffix, not prefix) the target triplet onto ${name}?
Or should I drop this idea that generally any store path can be created equally by either cross or native compilation?
There was a problem hiding this comment.
@bjornfor so we prefix for target != host and suffix for host != build :D. The former actually creates a meaningfully different derivation, while the latter ought to just be the implementation detail you want to hide. So don't worry, nothing here gets you farther from that.
Ericson2314
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It makes future cross work a lot easier to replicate from GHC to GHC.
Things done
No hashes should be changed. I tested the normalized URLs without caches to ensure they still worked.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)