Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtorrentRasterbar: 1.1.5 -> 1.1.6, switch deluge to libtorrentRasterbar & removed libtorrentRasterbar_1_0 #33402

Merged
merged 4 commits into from Jan 4, 2018
Merged

libtorrentRasterbar: 1.1.5 -> 1.1.6, switch deluge to libtorrentRasterbar & removed libtorrentRasterbar_1_0 #33402

merged 4 commits into from Jan 4, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jan 3, 2018 •
edited

Motivation for this change

The recent boost bump started causing issues with libtorrentRasterbar. The update to 1.1.6 fixes the issue since upstream now includes support for a more recent boost version.

We can also remove libtorrentRasterbar_1_0 after switching deluge to libtorrentRasterbar.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • test using with deluge(d)
  • Fits CONTRIBUTING.md.

@andir andir mentioned this pull request Jan 3, 2018
Closed
8 tasks
@andir andir changed the title libtorrentRasterbar: 1.1.5 -> 1.1.6 libtorrentRasterbar: 1.1.5 -> 1.1.6, switch deluge to libtorrentRasterbar & removed libtorrentRasterbar_1_0 Jan 3, 2018
@adisbladis
Copy link
Member

adisbladis commented Jan 3, 2018 •
edited

qbittorrent was still using libtorrentRasterbar_1_0 (breaking eval).
I bumped the version number and changed the libtorrent version.

@andir
Copy link
Member Author

andir commented Jan 3, 2018

Thanks, must have overlooked that and should finally add the pre-commit eval check :/

@andir
Copy link
Member Author

andir commented Jan 4, 2018

I just re-compiled qbittorrent as proposed here. Successfully downloaded an Debian ISO. 👍

@adisbladis adisbladis merged commit e7524ad into NixOS:master Jan 4, 2018
@adisbladis
Copy link
Member

Thanks :) 👍

@andir andir deleted the libtorrent-rastabar-1.1.6 branch January 4, 2018 00:46
infinisil added a commit to infinisil/system that referenced this pull request Mar 18, 2018
@infinisil
deluge: downgrade because global limits not working
d6a1af0 
With at least version 1.1.6 of libtorrent-rasterbar the global bandwidth
limits on upload/download don't apply (per-torrent limits still work).
1.1.7 is not out yet and the commit
arvidn/libtorrent@eb9f7c4
(about 19 Feb 2018) doesn't fix it either (all later commits give a
runtime error when starting). libtorrent-rasterbar version 1.1.5 doesn't build
(see NixOS/nixpkgs#33402).

Also see https://dev.deluge-torrent.org/ticket/3153 and https://forum.deluge-torrent.org/viewtopic.php?p=227823

This commit uses the latest version before the boost 1.66 upgrade which
makes 1.1.5 not build. There are no problems with that version regarding
bandwidth limiting.
@infinisil
Copy link
Member

infinisil commented Mar 18, 2018 •
edited

Version 1.1.6 makes global bandwidth limits in Deluge not work anymore, see https://forum.deluge-torrent.org/viewtopic.php?p=227823

I'm therefore using an older version of nixpkgs before the boost upgrade to have a deluge with bandwidth limits. I'm hoping upstream fixes this asap, master doesn't currently work either (gives a runtime error). See infinisil/system@d6a1af0

@andir
Copy link
Member Author

andir commented Mar 18, 2018

@infinisil thanks for reporting that. Can you check the upstream project for the correct bug report/fix? We might want to apply a patch until there is a new release.

@infinisil
Copy link
Member

@andir There is no bug report for libtorrent, only the one for deluge linked in my commit (https://dev.deluge-torrent.org/ticket/3153), but there's no patch.. :(

@andir
Copy link
Member Author

andir commented Mar 18, 2018

Can you open one? :)

@infinisil
Copy link
Member

arvidn/libtorrent#2857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @adisbladis @infinisil @GrahamcOfBorg