Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 12b9f0f7ee33
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cff68974d071
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jan 2, 2018

  1. Add #test_define_method_with_symbol to test targets

    Currently `#test_define_method_with_symbol` does not fail.
    yui-knk committed Jan 2, 2018
    Copy the full SHA
    429aca4 View commit details

Commits on Jan 3, 2018

  1. Merge pull request #4933 from yui-knk/test_define_method_with_symbol

    Add `#test_define_method_with_symbol` to test targets
    enebo authored Jan 3, 2018
    Copy the full SHA
    cff6897 View commit details
Showing with 0 additions and 1 deletion.
  1. +0 −1 test/mri/excludes/TestMethod.rb
1 change: 0 additions & 1 deletion test/mri/excludes/TestMethod.rb
Original file line number Diff line number Diff line change
@@ -2,7 +2,6 @@
exclude :test_body, "fails due RubyVM constant"
exclude :test_callee, "needs investigation"
exclude :test_define_method_visibility, "needs investigation"
exclude :test_define_method_with_symbol, "scope changes in define_method methods?"
exclude :test_gced_bmethod, "often 'Timeout::Error: execution of assert_normal_exit expired' on CI"
exclude :test_inspect, "fails since an alias-ed method does not distinguish owner and implementor module"
exclude :test_hash, "won't pass since Array#map is not a Array#collect alias as in MRI"