Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: preFixupPhases should be a string, and not an array #33394

Merged
merged 1 commit into from Jan 6, 2018
Merged

glib: preFixupPhases should be a string, and not an array #33394

merged 1 commit into from Jan 6, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 3, 2018

Motivation for this change

Fixes #33388.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@romildo @orivej
glib: fix pre phases
d51897e 
*Phases are strings, not arrays.
@orivej orivej changed the base branch from master to staging January 6, 2018 02:33
@orivej orivej merged commit aa3fa39 into NixOS:staging Jan 6, 2018
@orivej
Copy link
Contributor

orivej commented Jan 6, 2018

Thanks!

@romildo romildo deleted the fix.glib branch January 6, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: mass-rebuild 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @orivej @jtojnar @GrahamcOfBorg