Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-lock-plus: 2017-0222.1755 -> 20180101.25 #33387

Merged
merged 1 commit into from Jan 3, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Jan 3, 2018

Motivation for this change

Also specified specific revisions of the file to download to not have
a breaking package whenever the author decides to update the package.

This happened on 2018-01-01 when the author updated the copyright of
the package to match the new year.

I have not managed to build it with nox, nox promptly told me that there was no change, which I don't agree to. And I've also been unable to build it with nix-build like this:

nix-build -A emacsPackagesNgGen.font-lock-plus
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Also specified specific revisions of the file to download to not have
a breaking package whenever the author decides to update the package.

This happened on 2018-01-01 when the author updated the copyright of
the package to match the new year.
@adisbladis adisbladis merged commit d2e8c20 into NixOS:master Jan 3, 2018
@etu etu deleted the font-lock-plus branch January 3, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants