Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix String#rpartition for RegEx on Strings with multibyte chars #5026

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Fix String#rpartition for RegEx on Strings with multibyte chars #5026

merged 1 commit into from
Feb 1, 2018
+4 −7

Conversation

ChrisBr
Copy link
Contributor

@ChrisBr ChrisBr commented Feb 1, 2018

because before it used the wrong index when there was a mulitbyte character in the string.
We now let handle rindex function the index detection.

@ChrisBr
Fix String#rpartition for RegEx on Strings with multibyte chars
2c7b8f2 
because before it used the wrong index when there was a mulitbyte character in the string.
We now let handle rindex function the index detection.
@enebo enebo added this to the JRuby 9.2.0.0 milestone Feb 1, 2018
@enebo enebo merged commit f8de9a0 into jruby:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChrisBr @enebo