charliecloud: init at 0.2.2 #34484
Closed
charliecloud: init at 0.2.2 #34484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewo
requested changes
Feb 1, 2018
| bats_version = "0.4.0"; | ||
|
|
||
| srcs = | ||
| [ (fetchurl { |
| sha256 = "0djq3j6q7zj4ignf1b87k64bg4h5aw8l0mxnshagsaskwvmhakpi"; | ||
| }) | ||
| (fetchurl { | ||
| url = "https://github.com/sstephenson/bats/archive/v${bats_version}.tar.gz"; |
There was a problem hiding this comment.
bats is already available in nixpkgs. Would it be possible to use?
|
|
||
| patches = [ ./CONDUCT.md_not_present_into_bats_release.patch ]; | ||
|
|
||
| buildInputs = [ bash python ]; |
There was a problem hiding this comment.
I guess bash is provided by stdenv so, it is not necessary to include it.
| @@ -14479,6 +14479,8 @@ with pkgs; | |||
| amdappsdk = amdappsdk28; | |||
| }; | |||
|
|
|||
| charliecloud = callPackage ../applications/virtualization/charliecloud { }; | |||
|
|
|||
|
@bzizou Are you still interested in this? If so, please fix the mentioned issues. |
|
@pSub Yes, sorry! I check that asap... |
|
Charliecloud has a lot of new versions and changes. I'll do another PR with the latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Want to use charliecloud :-)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)