Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-power-manager: init at 3.26.0 #34480

Merged
merged 1 commit into from Feb 1, 2018
Merged

gnome-power-manager: init at 3.26.0 #34480

merged 1 commit into from Feb 1, 2018

Conversation

samdroid-apps
Copy link
Contributor

Motivation for this change

Provides an app to view battery and power statistics. This app is badly
documented on the web, but is in the default Fedora install; hence to
motivation to add it to Nix.

Testing
nix-env -i gnome-power-manager -f ~/nixpkgs/
gnome-power-statistics

It should launch and show some power statistics!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS - N/A
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added this to In Progress in GNOME Feb 1, 2018
jtojnar
jtojnar reviewed Feb 1, 2018
View reviewed changes
pkgs/desktops/gnome-3/apps/gnome-power-manager/default.nix Outdated
gtk3
glib
upower
intltool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intltool is a nativeBuildInput.

pkgs/desktops/gnome-3/apps/gnome-power-manager/default.nix Outdated
upower
intltool
gnome3.defaultIconTheme
gnome3.gsettings_desktop_schemas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not look like the schemas are used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app creates it's own gsettings: https://github.com/GNOME/gnome-power-manager/blob/9c91bf6ed47265466f06677fddb1940bebfd6e9e/src/gpm-statistics.c#L1923

What does gnome3.gesttings_desktop_schemas do? Does it provides some default gsettings?

@jtojnar jtojnar added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) labels Feb 1, 2018
@samdroid-apps
Copy link
Contributor Author

Thanks for the review @jtojnar; I've force pushed an update that addresses both comments.

Re removing gsettings_desktop_schemas; it still works on my environment. But I wonder if that is only because I already have gnome3 installed.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 1, 2018

I do not see the schemas mentioned anywhere in the code. Well they might still be needed by GTK itself but that was handled by #31891.

@samdroid-apps @jtojnar
gnome-power-manager: init at 3.26.0
d2f065b 
Provides an app to view battery and power statistics.  This app is badly
documented on the web, but is in the default Fedora install; hence to
motivation to add it to Nix.
@jtojnar
Copy link
Contributor

jtojnar commented Feb 1, 2018

Thanks.

@jtojnar jtojnar merged commit d2f065b into NixOS:master Feb 1, 2018
GNOME automation moved this from In Progress to Done Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
GNOME
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samdroid-apps @jtojnar @GrahamcOfBorg