Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkite-agent: enable building on darwin #34488

Merged
merged 1 commit into from Feb 1, 2018
Merged

buildkite-agent: enable building on darwin #34488

merged 1 commit into from Feb 1, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Feb 1, 2018

Motivation for this change

It builds and runs on Darwin without modification.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@domenkozar
Copy link
Member

@GrahamcOfBorg build buildkite-agent

domenkozar
domenkozar reviewed Feb 1, 2018
View reviewed changes
pkgs/development/tools/continuous-integration/buildkite-agent/default.nix
@@ -44,6 +44,6 @@ buildGoPackage {
homepage = https://buildkite.com/docs/agent;
license = licenses.mit;
maintainers = with maintainers; [ pawelpacana zimbatm ];
platforms = platforms.linux;
platforms = platforms.linux ++ platforms.darwin;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to just say platforms.unix

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/8y56qnbypa8v3ppidwl63gqirbczms4c-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/post-command.sample: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/8y56qnbypa8v3ppidwl63gqirbczms4c-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/post-artifact.sample: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/8y56qnbypa8v3ppidwl63gqirbczms4c-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/post-checkout.sample: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/8y56qnbypa8v3ppidwl63gqirbczms4c-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/pre-checkout.sample: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/8y56qnbypa8v3ppidwl63gqirbczms4c-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/pre-command.sample: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/8y56qnbypa8v3ppidwl63gqirbczms4c-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/hooks/pre-artifact.sample: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/8y56qnbypa8v3ppidwl63gqirbczms4c-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/lsb/buildkite-agent.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
/nix/store/8y56qnbypa8v3ppidwl63gqirbczms4c-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/packaging/linux/root/usr/share/buildkite-agent/docker-cleanup.sh: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-buildkite-agent-2.6.6.drv-0 in /nix/store/8y56qnbypa8v3ppidwl63gqirbczms4c-buildkite-agent-2.6.6...
/nix/store/1mqqws95vljx84jpwij89wl8m220jk9b-buildkite-agent-2.6.6-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/j02r81jk87xmj5sq214943i6ds741ywr-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/scripts/publish-to-s3.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/j02r81jk87xmj5sq214943i6ds741ywr-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/templates/0.2/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/j02r81jk87xmj5sq214943i6ds741ywr-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/templates/1.0-beta.1-6/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/j02r81jk87xmj5sq214943i6ds741ywr-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/templates/bootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/j02r81jk87xmj5sq214943i6ds741ywr-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/j02r81jk87xmj5sq214943i6ds741ywr-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/j02r81jk87xmj5sq214943i6ds741ywr-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/j02r81jk87xmj5sq214943i6ds741ywr-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/j02r81jk87xmj5sq214943i6ds741ywr-buildkite-agent-2.6.6/share/go/src/github.com/buildkite/agent/vendor/github.com/kr/pty/mktypes.bash: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/p58wf8gd2gfmwdq0sl12k1q7038rgy6n-buildkite-agent-2.6.6-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xi4f9mm0ax2dqjbqgr9n2gx7wqhcs3g2-buildkite-agent-2.6.6-bin
shrinking /nix/store/xi4f9mm0ax2dqjbqgr9n2gx7wqhcs3g2-buildkite-agent-2.6.6-bin/bin/.buildkite-agent-wrapped
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/xi4f9mm0ax2dqjbqgr9n2gx7wqhcs3g2-buildkite-agent-2.6.6-bin/libexec  /nix/store/xi4f9mm0ax2dqjbqgr9n2gx7wqhcs3g2-buildkite-agent-2.6.6-bin/bin
patching script interpreter paths in /nix/store/xi4f9mm0ax2dqjbqgr9n2gx7wqhcs3g2-buildkite-agent-2.6.6-bin
checking for references to /build in /nix/store/xi4f9mm0ax2dqjbqgr9n2gx7wqhcs3g2-buildkite-agent-2.6.6-bin...
wrapper script /nix/store/xi4f9mm0ax2dqjbqgr9n2gx7wqhcs3g2-buildkite-agent-2.6.6-bin/bin/buildkite-agent contains a forbidden reference to /build
builder for '/nix/store/dshgwh9m9dc3xn5f6cgl81cawyw5sd2i-buildkite-agent-2.6.6.drv' failed with exit code 1
error: build of '/nix/store/dshgwh9m9dc3xn5f6cgl81cawyw5sd2i-buildkite-agent-2.6.6.drv' failed

@domenkozar domenkozar merged commit 480e3f3 into NixOS:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar domenkozar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvl @domenkozar @GrahamcOfBorg