python.pkgs.ptyprocess: 0.5 -> 0.5.2 #34487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Feb 1, 2018
|
|
||
| src = fetchPypi { | ||
| inherit pname version; | ||
| sha256= "e64193f0047ad603b71f202332ab5527c5e52aa7c8b609704fc28c0dc20c4365"; |
There was a problem hiding this comment.
Missing blank.
And why don't you use short hash? 0ra31k10v3629xq0kdn8lwmfbi97anmk48r03yvh7mks0kq96hg6
There was a problem hiding this comment.
Simple copy-paste from PyPI ;-)
There was a problem hiding this comment.
I must be blind. Where did you find sha256? I only see md5
There was a problem hiding this comment.
|
Pushed as 356b553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)