Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networking-interfaces: add preferTempAddress option #34492

Merged
merged 2 commits into from Feb 17, 2018
Merged

nixos/networking-interfaces: add preferTempAddress option #34492

merged 2 commits into from Feb 17, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 1, 2018 •
edited

Motivation for this change

Most operating systems implement IPv6 privacy extensions and are using temporary address for outbound connections by default. NixOS should do the same.

Things done
  • Tested via tests/networking.nix (doesn't break anything)
  • Test if temporary addresses are actually being used
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj changed the title [WIP] nixos/networking-interfaces: add preferTempAddress option nixos/networking-interfaces: add preferTempAddress option Feb 1, 2018
@joachifm
Copy link
Contributor

@GrahamcOfBorg test networking.networkd.privacy

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

client: exit status 0
router: running command: sync
router: exit status 0
test script finished in 21.01s
cleaning up
killing client (pid 593)
killing router (pid 604)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/6rf95k82iaf8q1z6vv4c5nzn2is7w4jn-vm-test-run-Privacy-Networking-Networkd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

client: exit status 0
router: running command: sync
router: exit status 0
test script finished in 30.18s
cleaning up
killing client (pid 627)
killing router (pid 639)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/d37ic2bb19pald5j7m7z3a4k6rdm6j30-vm-test-run-Privacy-Networking-Networkd

@joachifm joachifm merged commit 7bf049a into NixOS:master Feb 17, 2018
@vcunat
Copy link
Member

vcunat commented Feb 19, 2018 •
edited

The ipv6 test is broken on master and reverting this merge fixes it for me locally. (I didn't look into why it breaks.)

@vcunat vcunat mentioned this pull request Feb 19, 2018
Closed
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 19, 2018

Ah, I didn't notice there were more networking tests outside networking.nix.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 19, 2018 •
edited

It looks like it checks if there is exactly one address, now there are 2 at least. It's seems trivial to fix.

@rnhmjoj rnhmjoj mentioned this pull request Feb 19, 2018
Merged
2 tasks
@vcunat
Copy link
Member

vcunat commented Feb 19, 2018

Thanks for the very fast fix (< 1h).

@erictapen erictapen mentioned this pull request Feb 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @joachifm @GrahamcOfBorg @vcunat