Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LB-300: Fix artist counts on user page #346

Merged
merged 2 commits into from Feb 1, 2018
Merged

LB-300: Fix artist counts on user page #346

merged 2 commits into from Feb 1, 2018

Conversation

paramsingh
Copy link
Collaborator

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other

Problem

  • JIRA ticket (optional): LB-300

the dict wasn't being used correctly, probably an after effect of changing the tables
from plural to singular.

Solution

Use artist instead of artists and add a test.

@paramsingh
Fix incorrect usage of the user stats dict
6156928 
Now artist count should be shown correctly, also
add a test to make sure no regressions happen.
@paramsingh
Fix typo in test docstring
b62260f
mayhem
mayhem approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚦 🚗 🦀

@mayhem mayhem merged commit 77d1514 into metabrainz:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayhem mayhem mayhem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@paramsingh @mayhem