dcm2niix: init at 1.0.20170130 #33883
Conversation
| , libyamlcpp | ||
| }: | ||
|
|
||
| let |
There was a problem hiding this comment.
Since you are using a recursive attribute set you might as well skip the let block entirely and put these attributes on the derivation attribute set.
| }: | ||
|
|
||
| let | ||
| version = "v1.0.20170130"; |
There was a problem hiding this comment.
It's common practice not to have the "v" in the version number attribute but instead in the rev attribute passed to fetchFromGitHub.
| }; | ||
|
|
||
| enableParallelBuilding = true; | ||
| buildInputs = [ cmake libyamlcpp]; |
There was a problem hiding this comment.
cmake should be in nativeBuildInputs
| DICOM format to the NIfTI format. | ||
| ''; | ||
| homepage = https://www.nitrc.org/projects/dcm2nii; | ||
| license = stdenv.lib.licenses.bsd3; |
There was a problem hiding this comment.
You could simplify the meta attributes by using the with stdenv.lib syntax on the meta attribute.
| homepage = https://www.nitrc.org/projects/dcm2nii; | ||
| license = stdenv.lib.licenses.bsd3; | ||
| maintainers = [ stdenv.lib.maintainers.ashgillman ]; | ||
| platforms = stdenv.lib.platforms.linux; |
There was a problem hiding this comment.
This software seems to be compatible with darwin too. I think that maybe this should be platforms.all instead.
There was a problem hiding this comment.
Thanks for your feedback. Should this be the case given that I haven't tested against darwin?
There was a problem hiding this comment.
We have a bot (@GrahamcOfBorg) that will at least do a build test on darwin.
|
|
||
| let | ||
| version = "v1.0.20170130"; | ||
| sha256 = "1f2nzd8flp1rfn725bi64z7aw3ccxyyygzarxijw6pvgl476i532"; |
There was a problem hiding this comment.
Please move to fetchFromGitHub.
|
Please change commit message to |
ashgillman
force-pushed
the
add-dcm2niix
branch
from
dabc617
to
245a67d
Compare
|
@GrahamcOfBorg build dcm2niix |
There was a problem hiding this comment.
Success for system: x86_64-linux
-- Install configuration: "Release"
-- Installing: /nix/store/xpny9fbwvk8wnym6zdp6q3h0lbzlgz52-dcm2niix-1.0.20170130/bin/dcm2niix
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xpny9fbwvk8wnym6zdp6q3h0lbzlgz52-dcm2niix-1.0.20170130
shrinking /nix/store/xpny9fbwvk8wnym6zdp6q3h0lbzlgz52-dcm2niix-1.0.20170130/bin/dcm2niix
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/xpny9fbwvk8wnym6zdp6q3h0lbzlgz52-dcm2niix-1.0.20170130/bin
patching script interpreter paths in /nix/store/xpny9fbwvk8wnym6zdp6q3h0lbzlgz52-dcm2niix-1.0.20170130
checking for references to /tmp/nix-build-dcm2niix-1.0.20170130.drv-0 in /nix/store/xpny9fbwvk8wnym6zdp6q3h0lbzlgz52-dcm2niix-1.0.20170130...
/nix/store/xpny9fbwvk8wnym6zdp6q3h0lbzlgz52-dcm2niix-1.0.20170130
There was a problem hiding this comment.
Success for system: x86_64-darwin
install flags: install SHELL=/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/bash
[100%] Built target dcm2niix
Install the project...
-- Install configuration: "Release"
-- Installing: /nix/store/i91iiqzd9wlpw69wb64fyl7pzh8y981b-dcm2niix-1.0.20170130/bin/dcm2niix
post-installation fixup
strip is /nix/store/bhfkh37smh9lc5bngdha6zx98k6w6cgd-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/i91iiqzd9wlpw69wb64fyl7pzh8y981b-dcm2niix-1.0.20170130/bin
patching script interpreter paths in /nix/store/i91iiqzd9wlpw69wb64fyl7pzh8y981b-dcm2niix-1.0.20170130
/nix/store/i91iiqzd9wlpw69wb64fyl7pzh8y981b-dcm2niix-1.0.20170130
There was a problem hiding this comment.
Success for system: aarch64-linux
-- Install configuration: "Release"
-- Installing: /nix/store/dynvqc5wn4lwji40d4y1d56rjl7ng4qp-dcm2niix-1.0.20170130/bin/dcm2niix
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dynvqc5wn4lwji40d4y1d56rjl7ng4qp-dcm2niix-1.0.20170130
shrinking /nix/store/dynvqc5wn4lwji40d4y1d56rjl7ng4qp-dcm2niix-1.0.20170130/bin/dcm2niix
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dynvqc5wn4lwji40d4y1d56rjl7ng4qp-dcm2niix-1.0.20170130/bin
patching script interpreter paths in /nix/store/dynvqc5wn4lwji40d4y1d56rjl7ng4qp-dcm2niix-1.0.20170130
checking for references to /build in /nix/store/dynvqc5wn4lwji40d4y1d56rjl7ng4qp-dcm2niix-1.0.20170130...
/nix/store/dynvqc5wn4lwji40d4y1d56rjl7ng4qp-dcm2niix-1.0.20170130
|
Thanks! :) |
Motivation for this change
Add a package used in biomedical imaging
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)