Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-frameworks: 5.41 -> 5.42 #33857

Merged
merged 1 commit into from Jan 15, 2018
Merged

kde-frameworks: 5.41 -> 5.42 #33857

merged 1 commit into from Jan 15, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jan 14, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @ttuegel @bkchr @peterhoeg

@bkchr
Copy link
Contributor

bkchr commented Jan 14, 2018

I'm compiling it now :)

@bkchr
Copy link
Contributor

bkchr commented Jan 14, 2018

Works for me :)
@ttuegel after merging that, will you merge qt5.10?

@adisbladis adisbladis merged commit edd712e into NixOS:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @bkchr @ttuegel @GrahamcOfBorg