Comparing changes
Open a pull request
- 8 commits
- 8 files changed
- 2 contributors
Commits on Jan 14, 2018
-
Extract parseRegexpFlags to Lexer
And use the same function from both Ripper and main parser.
-
Move Regexp checking from ParserSupport to Lexer
While not really related to Lexing, this is a component that is shared between Ripper and the main parser, and that seemed like the lesser evil.
-
Align validation code with MRI
It seems to have been `!ENCODING_IS_ASCII8BIT(str)` from the beginning, so I'm not sure why it was the opposite here.
-
Make sure to clear $! when rescuing RaiseException
The code was copied from Parser support, so it was clearly broken before, but it had to be fixed now as parts of the Ripper test suite relies on $! rather than explicitly catching the exception.
-
Add support for validating Regexp in Ripper
This uses the fact that Regexp tokenization is handled by a single StringTerm, and thus all tSTRING_CONTENT fragments are easily collectable until the tREGEXP_END comes with the options that we need for validation. The validation itself is a copied/simplified version of what is performed by the main parser, as large parts the validation depended on the AST structure, which we do not have here. Technically, this doesn't perform the validation at the same point in time as the main parser, as it performs the validation when encountering the tREGEXP_END token rather than when processing the regexp rule. I speculate that the difference doesn't really matter given that the only thing we could do with the tREGEXP_END token is to apply the regexp rule.
-
Simplify the regexp validation logic
Use a separate variable to track whether things are dynamic or not, and use a List to avoid tracking the last element explicitly.
-
Inline the regexp validation inside ParserSupport
The methods were only retained to provide the old interface, but by directly calling the new methods in the Lexer, we can remove the old methods, given that we don't really need to be backwards compatible here.
-
Merge pull request #4902 from grddev/ripper-regex
Add support for validating Regexp in Ripper
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff c9790ea19b97...2614c773b8f4