Feature/string casecmp #4975
Merged
Feature/string casecmp #4975
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisBr if checkStringType doesnt return nil you can safely cast it to RubyString, otherwise you're doing the conversion twice here by calling convertToString. |
ChrisBr
force-pushed
the
feature/string-casecmp
branch
from
1323239 to
002e2c4
Compare
ChrisBr
force-pushed
the
feature/string-casecmp
branch
from
002e2c4 to
bdd7b2f
Compare
|
@lopex you're right, fixed |
|
Please note that the casecmp? test is excluded from the test suite because of missing case-fold logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to return nil for incompatible types instead of raising exception.
Support for Ruby 2.5
See feature https://bugs.ruby-lang.org/issues/13312.