Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netsniff-ng: 0.6.2 -> 0.6.3 #33881

Closed
wants to merge 1 commit into from
Closed

netsniff-ng: 0.6.2 -> 0.6.3 #33881

wants to merge 1 commit into from

Conversation

dhess
Copy link
Contributor

@dhess dhess commented Jan 15, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@GrahamcOfBorg build netsniff-ng

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3/sbin/mausezahn
shrinking /nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3/sbin/astraceroute
shrinking /nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3/sbin/curvetun
gzipping man pages under /nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3/sbin 
patching script interpreter paths in /nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3
checking for references to /tmp/nix-build-netsniff-ng-0.6.3.drv-0 in /nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3...
moving /nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3/sbin/* to /nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3/bin
/nix/store/bhdn4dgcq5gryy8jp0rk951baqisp837-netsniff-ng-0.6.3

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘netsniff-ng-0.6.3’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/tools/networking/netsniff-ng/default.nix:49 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

shrinking /nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3/sbin/astraceroute
shrinking /nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3/sbin/trafgen
shrinking /nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3/sbin/netsniff-ng
gzipping man pages under /nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3/share/man/
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3/sbin
patching script interpreter paths in /nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3
checking for references to /build in /nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3...
moving /nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3/sbin/* to /nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3/bin
/nix/store/y2lqcl03j386ccwr1k807j82d3kbv9c9-netsniff-ng-0.6.3

@@ -20,6 +20,9 @@ stdenv.mkDerivation rec {
libnetfilter_conntrack libpcap libsodium liburcu ncurses perl
pkgconfig zlib ];

# trafgen can call out to cpp to process config files.
propagatedBuildInputs = [ stdenv.cc ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting stdenv.cc in propagatedBuildInputs won't make it available at runtime. You need to either patch the source to use nix-store path or use wrapProgram.

@dhess
Copy link
Contributor Author

dhess commented Jan 16, 2018

Fixed the wrapProgram issue.

@adisbladis
Copy link
Member

adisbladis commented Jan 16, 2018

Pushed in fa3d1c5. Thanks!

@adisbladis adisbladis closed this Jan 16, 2018
@dhess dhess deleted the netsniff-ng-0.6.3 branch January 17, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants