Skip to content

Commit 793f031

Browse files
andrewrkandrewrk
committedJan 14, 2018
remove 32-bit windows from supported targets list
we still want to support it, but there are too many bugs to claim that we support it right now. See #537
·
0.15.20.2.0
1 parent e7e7625 commit 793f031

File tree

21 files changed

+1
-178
lines changed

21 files changed

+1
-178
lines changed
 

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ that counts as "freestanding" for the purposes of this table.
5454

5555
| | freestanding | linux | macosx | windows | other |
5656
|-------------|--------------|---------|---------|---------|---------|
57-
|i386 | OK | planned | OK | OK | planned |
57+
|i386 | OK | planned | OK | planned | planned |
5858
|x86_64 | OK | OK | OK | OK | planned |
5959
|arm | OK | planned | planned | N/A | planned |
6060
|aarch64 | OK | planned | planned | planned | planned |

‎src-self-hosted/parser.zig‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1146,12 +1146,6 @@ fn testCanonical(source: []const u8) {
11461146
}
11471147

11481148
test "zig fmt" {
1149-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
1150-
// TODO get this test passing
1151-
// https://github.com/zig-lang/zig/issues/537
1152-
return;
1153-
}
1154-
11551149
testCanonical(
11561150
\\extern fn puts(s: &const u8) -> c_int;
11571151
\\

‎std/crypto/sha2.zig‎

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -270,22 +270,12 @@ fn Sha2_32(comptime params: Sha2Params32) -> type { return struct {
270270
};}
271271

272272
test "sha224 single" {
273-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
274-
// https://github.com/zig-lang/zig/issues/537
275-
return;
276-
}
277-
278273
debug.assert(0xd14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f == Sha224.hash(""));
279274
debug.assert(0x23097d223405d8228642a477bda255b32aadbce4bda0b3f7e36c9da7 == Sha224.hash("abc"));
280275
debug.assert(0xc97ca9a559850ce97a04a96def6d99a9e0e0e2ab14e6b8df265fc0b3 == Sha224.hash("abcdefghbcdefghicdefghijdefghijkefghijklfghijklmghijklmnhijklmnoijklmnopjklmnopqklmnopqrlmnopqrsmnopqrstnopqrstu"));
281276
}
282277

283278
test "sha224 streaming" {
284-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
285-
// https://github.com/zig-lang/zig/issues/537
286-
return;
287-
}
288-
289279
var h = Sha224.init();
290280

291281
debug.assert(0xd14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f == h.final());
@@ -302,22 +292,12 @@ test "sha224 streaming" {
302292
}
303293

304294
test "sha256 single" {
305-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
306-
// https://github.com/zig-lang/zig/issues/537
307-
return;
308-
}
309-
310295
debug.assert(0xe3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 == Sha256.hash(""));
311296
debug.assert(0xba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad == Sha256.hash("abc"));
312297
debug.assert(0xcf5b16a778af8380036ce59e7b0492370b249b11e8f07a51afac45037afee9d1 == Sha256.hash("abcdefghbcdefghicdefghijdefghijkefghijklfghijklmghijklmnhijklmnoijklmnopjklmnopqklmnopqrlmnopqrsmnopqrstnopqrstu"));
313298
}
314299

315300
test "sha256 streaming" {
316-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
317-
// https://github.com/zig-lang/zig/issues/537
318-
return;
319-
}
320-
321301
var h = Sha256.init();
322302

323303
debug.assert(0xe3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 == h.final());
@@ -621,11 +601,6 @@ fn Sha2_64(comptime params: Sha2Params64) -> type { return struct {
621601
};}
622602

623603
test "sha384 single" {
624-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
625-
// https://github.com/zig-lang/zig/issues/537
626-
return;
627-
}
628-
629604
const h1 = 0x38b060a751ac96384cd9327eb1b1e36a21fdb71114be07434c0cc7bf63f6e1da274edebfe76f65fbd51ad2f14898b95b;
630605
debug.assert(h1 == Sha384.hash(""));
631606

@@ -637,11 +612,6 @@ test "sha384 single" {
637612
}
638613

639614
test "sha384 streaming" {
640-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
641-
// https://github.com/zig-lang/zig/issues/537
642-
return;
643-
}
644-
645615
var h = Sha384.init();
646616

647617
const h1 = 0x38b060a751ac96384cd9327eb1b1e36a21fdb71114be07434c0cc7bf63f6e1da274edebfe76f65fbd51ad2f14898b95b;
@@ -661,11 +631,6 @@ test "sha384 streaming" {
661631
}
662632

663633
test "sha512 single" {
664-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
665-
// https://github.com/zig-lang/zig/issues/537
666-
return;
667-
}
668-
669634
const h1 = 0xcf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e;
670635
debug.assert(h1 == Sha512.hash(""));
671636

@@ -677,11 +642,6 @@ test "sha512 single" {
677642
}
678643

679644
test "sha512 streaming" {
680-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
681-
// https://github.com/zig-lang/zig/issues/537
682-
return;
683-
}
684-
685645
var h = Sha512.init();
686646

687647
const h1 = 0xcf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e;

‎std/io_test.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@ const os = std.os;
88
const builtin = @import("builtin");
99

1010
test "write a file, read it, then delete it" {
11-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
12-
// TODO get this test passing
13-
// https://github.com/zig-lang/zig/issues/537
14-
return;
15-
}
1611
var data: [1024]u8 = undefined;
1712
var rng = Rand.init(1234);
1813
rng.fillBytes(data[0..]);

‎std/math/acosh.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,6 @@ fn acosh64(x: f64) -> f64 {
5555
}
5656

5757
test "math.acosh" {
58-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
59-
// TODO get this test passing
60-
// https://github.com/zig-lang/zig/issues/537
61-
return;
62-
}
6358
assert(acosh(f32(1.5)) == acosh32(1.5));
6459
assert(acosh(f64(1.5)) == acosh64(1.5));
6560
}

‎std/math/cos.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -146,11 +146,6 @@ test "math.cos" {
146146
}
147147

148148
test "math.cos32" {
149-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
150-
// TODO get this test passing
151-
// https://github.com/zig-lang/zig/issues/537
152-
return;
153-
}
154149
const epsilon = 0.000001;
155150

156151
assert(math.approxEq(f32, cos32(0.0), 1.0, epsilon));

‎std/math/cosh.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,6 @@ fn cosh64(x: f64) -> f64 {
8181
}
8282

8383
test "math.cosh" {
84-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
85-
// TODO get this test passing
86-
// https://github.com/zig-lang/zig/issues/537
87-
return;
88-
}
8984
assert(cosh(f32(1.5)) == cosh32(1.5));
9085
assert(cosh(f64(1.5)) == cosh64(1.5));
9186
}

‎std/math/index.zig‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -359,11 +359,6 @@ pub fn divTrunc(comptime T: type, numerator: T, denominator: T) -> %T {
359359
}
360360

361361
test "math.divTrunc" {
362-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
363-
// TODO get this test passing
364-
// https://github.com/zig-lang/zig/issues/537
365-
return;
366-
}
367362
testDivTrunc();
368363
comptime testDivTrunc();
369364
}
@@ -389,11 +384,6 @@ pub fn divFloor(comptime T: type, numerator: T, denominator: T) -> %T {
389384
}
390385

391386
test "math.divFloor" {
392-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
393-
// TODO get this test passing
394-
// https://github.com/zig-lang/zig/issues/537
395-
return;
396-
}
397387
testDivFloor();
398388
comptime testDivFloor();
399389
}
@@ -423,11 +413,6 @@ pub fn divExact(comptime T: type, numerator: T, denominator: T) -> %T {
423413
}
424414

425415
test "math.divExact" {
426-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
427-
// TODO get this test passing
428-
// https://github.com/zig-lang/zig/issues/537
429-
return;
430-
}
431416
testDivExact();
432417
comptime testDivExact();
433418
}

‎std/math/ln.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,6 @@ pub fn ln_64(x_: f64) -> f64 {
147147
}
148148

149149
test "math.ln" {
150-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
151-
// TODO get this test passing
152-
// https://github.com/zig-lang/zig/issues/537
153-
return;
154-
}
155150
assert(ln(f32(0.2)) == ln_32(0.2));
156151
assert(ln(f64(0.2)) == ln_64(0.2));
157152
}

‎std/math/log.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,6 @@ test "math.log float" {
5656
}
5757

5858
test "math.log float_special" {
59-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
60-
// TODO get this test passing
61-
// https://github.com/zig-lang/zig/issues/537
62-
return;
63-
}
6459
assert(log(f32, 2, 0.2301974) == math.log2(f32(0.2301974)));
6560
assert(log(f32, 10, 0.2301974) == math.log10(f32(0.2301974)));
6661

‎std/math/log10.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,6 @@ pub fn log10_64(x_: f64) -> f64 {
172172
}
173173

174174
test "math.log10" {
175-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
176-
// TODO get this test passing
177-
// https://github.com/zig-lang/zig/issues/537
178-
return;
179-
}
180175
assert(log10(f32(0.2)) == log10_32(0.2));
181176
assert(log10(f64(0.2)) == log10_64(0.2));
182177
}

‎std/math/log2.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,6 @@ pub fn log2_64(x_: f64) -> f64 {
170170
}
171171

172172
test "math.log2" {
173-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
174-
// TODO get this test passing
175-
// https://github.com/zig-lang/zig/issues/537
176-
return;
177-
}
178173
assert(log2(f32(0.2)) == log2_32(0.2));
179174
assert(log2(f64(0.2)) == log2_64(0.2));
180175
}

‎std/math/pow.zig‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -176,12 +176,6 @@ fn isOddInteger(x: f64) -> bool {
176176
}
177177

178178
test "math.pow" {
179-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
180-
// TODO get this test passing
181-
// https://github.com/zig-lang/zig/issues/537
182-
return;
183-
}
184-
185179
const epsilon = 0.000001;
186180

187181
assert(math.approxEq(f32, pow(f32, 0.0, 3.3), 0.0, epsilon));

‎std/math/round.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,6 @@ test "math.round" {
9898
}
9999

100100
test "math.round32" {
101-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
102-
// TODO get this test passing
103-
// https://github.com/zig-lang/zig/issues/537
104-
return;
105-
}
106101
assert(round32(1.3) == 1.0);
107102
assert(round32(-1.3) == -1.0);
108103
assert(round32(0.2) == 0.0);

‎std/math/sin.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,6 @@ test "math.sin" {
150150
}
151151

152152
test "math.sin32" {
153-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
154-
// TODO get this test passing
155-
// https://github.com/zig-lang/zig/issues/537
156-
return;
157-
}
158153
const epsilon = 0.000001;
159154

160155
assert(math.approxEq(f32, sin32(0.0), 0.0, epsilon));

‎std/math/sinh.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,6 @@ fn sinh64(x: f64) -> f64 {
8888
}
8989

9090
test "math.sinh" {
91-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
92-
// TODO get this test passing
93-
// https://github.com/zig-lang/zig/issues/537
94-
return;
95-
}
9691
assert(sinh(f32(1.5)) == sinh32(1.5));
9792
assert(sinh(f64(1.5)) == sinh64(1.5));
9893
}

‎std/math/tan.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -136,11 +136,6 @@ test "math.tan" {
136136
}
137137

138138
test "math.tan32" {
139-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
140-
// TODO get this test passing
141-
// https://github.com/zig-lang/zig/issues/537
142-
return;
143-
}
144139
const epsilon = 0.000001;
145140

146141
assert(math.approxEq(f32, tan32(0.0), 0.0, epsilon));

‎std/math/tanh.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,6 @@ fn tanh64(x: f64) -> f64 {
112112
}
113113

114114
test "math.tanh" {
115-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
116-
// TODO get this test passing
117-
// https://github.com/zig-lang/zig/issues/537
118-
return;
119-
}
120115
assert(tanh(f32(1.5)) == tanh32(1.5));
121116
assert(tanh(f64(1.5)) == tanh64(1.5));
122117
}

‎std/rand.zig‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -194,11 +194,6 @@ fn MersenneTwister(
194194
}
195195

196196
test "rand float 32" {
197-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
198-
// TODO get this test passing
199-
// https://github.com/zig-lang/zig/issues/537
200-
return;
201-
}
202197
var r = Rand.init(42);
203198
var i: usize = 0;
204199
while (i < 1000) : (i += 1) {
@@ -209,35 +204,20 @@ test "rand float 32" {
209204
}
210205

211206
test "rand.MT19937_64" {
212-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
213-
// TODO get this test passing
214-
// https://github.com/zig-lang/zig/issues/537
215-
return;
216-
}
217207
var rng = MT19937_64.init(rand_test.mt64_seed);
218208
for (rand_test.mt64_data) |value| {
219209
assert(value == rng.get());
220210
}
221211
}
222212

223213
test "rand.MT19937_32" {
224-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
225-
// TODO get this test passing
226-
// https://github.com/zig-lang/zig/issues/537
227-
return;
228-
}
229214
var rng = MT19937_32.init(rand_test.mt32_seed);
230215
for (rand_test.mt32_data) |value| {
231216
assert(value == rng.get());
232217
}
233218
}
234219

235220
test "rand.Rand.range" {
236-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
237-
// TODO get this test passing
238-
// https://github.com/zig-lang/zig/issues/537
239-
return;
240-
}
241221
var r = Rand.init(42);
242222
testRange(&r, -4, 3);
243223
testRange(&r, -4, -1);

‎std/sort.zig‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1020,11 +1020,6 @@ fn cmpByValue(a: &const IdAndValue, b: &const IdAndValue) -> bool {
10201020
}
10211021

10221022
test "std.sort" {
1023-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
1024-
// TODO get this test passing
1025-
// https://github.com/zig-lang/zig/issues/537
1026-
return;
1027-
}
10281023
const u8cases = [][]const []const u8 {
10291024
[][]const u8{"", ""},
10301025
[][]const u8{"a", "a"},
@@ -1061,11 +1056,6 @@ test "std.sort" {
10611056
}
10621057

10631058
test "std.sort descending" {
1064-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
1065-
// TODO get this test passing
1066-
// https://github.com/zig-lang/zig/issues/537
1067-
return;
1068-
}
10691059
const rev_cases = [][]const []const i32 {
10701060
[][]const i32{[]i32{}, []i32{}},
10711061
[][]const i32{[]i32{1}, []i32{1}},
@@ -1085,23 +1075,13 @@ test "std.sort descending" {
10851075
}
10861076

10871077
test "another sort case" {
1088-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
1089-
// TODO get this test passing
1090-
// https://github.com/zig-lang/zig/issues/537
1091-
return;
1092-
}
10931078
var arr = []i32{ 5, 3, 1, 2, 4 };
10941079
sort(i32, arr[0..], i32asc);
10951080

10961081
assert(mem.eql(i32, arr, []i32{ 1, 2, 3, 4, 5 }));
10971082
}
10981083

10991084
test "sort fuzz testing" {
1100-
if (builtin.os == builtin.Os.windows and builtin.arch == builtin.Arch.i386) {
1101-
// TODO get this test passing
1102-
// https://github.com/zig-lang/zig/issues/537
1103-
return;
1104-
}
11051085
var rng = std.rand.Rand.init(0x12345678);
11061086
const test_case_count = 10;
11071087
var i: usize = 0;

‎test/tests.zig‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,6 @@ const test_targets = []TestTarget {
4242
.arch = builtin.Arch.x86_64,
4343
.environ = builtin.Environ.msvc,
4444
},
45-
TestTarget {
46-
.os = builtin.Os.windows,
47-
.arch = builtin.Arch.i386,
48-
.environ = builtin.Environ.msvc,
49-
},
5045
};
5146

5247
error TestFailed;

0 commit comments

Comments
 (0)
Please sign in to comment.