transmission: fix RCE via dns rebinding attach #33873
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For further details see [1] & [2]. [1] transmission/transmission#468 [2] http://www.openwall.com/lists/oss-security/2018/01/12/1
|
@GrahamcOfBorg test bittorrent |
|
@GrahamcOfBorg build transmission |
There was a problem hiding this comment.
Success for system: x86_64-linux
shrinking /nix/store/zzv6q1vjrysg0kznm2qyh67q5sfni2sb-transmission-2.92/bin/transmission-daemon
shrinking /nix/store/zzv6q1vjrysg0kznm2qyh67q5sfni2sb-transmission-2.92/bin/transmission-cli
shrinking /nix/store/zzv6q1vjrysg0kznm2qyh67q5sfni2sb-transmission-2.92/bin/transmission-show
shrinking /nix/store/zzv6q1vjrysg0kznm2qyh67q5sfni2sb-transmission-2.92/bin/transmission-remote
gzipping man pages under /nix/store/zzv6q1vjrysg0kznm2qyh67q5sfni2sb-transmission-2.92/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zzv6q1vjrysg0kznm2qyh67q5sfni2sb-transmission-2.92/bin
patching script interpreter paths in /nix/store/zzv6q1vjrysg0kznm2qyh67q5sfni2sb-transmission-2.92
checking for references to /tmp/nix-build-transmission-2.92.drv-0 in /nix/store/zzv6q1vjrysg0kznm2qyh67q5sfni2sb-transmission-2.92...
/nix/store/zzv6q1vjrysg0kznm2qyh67q5sfni2sb-transmission-2.92
There was a problem hiding this comment.
Failure for system: x86_64-linux
killing client2 (pid 594)
killing router (pid 604)
killing client1 (pid 616)
killing tracker (pid 626)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-bittorrent.drv-0/vde1.ctl': Directory not empty
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-bittorrent.drv-0/vde2.ctl': Directory not empty
builder for ‘/nix/store/ynms0fwcpq7c0b3grky7x1pcxmcmls8z-vm-test-run-bittorrent.drv’ failed with exit code 255
error: build of ‘/nix/store/ynms0fwcpq7c0b3grky7x1pcxmcmls8z-vm-test-run-bittorrent.drv’ failed
There was a problem hiding this comment.
Success for system: x86_64-darwin
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-transmission-2.92.drv-0/transmission-2.92'
make[1]: Leaving directory '/private/tmp/nix-build-transmission-2.92.drv-0/transmission-2.92'
post-installation fixup
gzipping man pages under /nix/store/rwbvp8rxgmzhr1m589j0b8jwky4sy5pg-transmission-2.92/share/man/
strip is /nix/store/bhfkh37smh9lc5bngdha6zx98k6w6cgd-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/rwbvp8rxgmzhr1m589j0b8jwky4sy5pg-transmission-2.92/bin
patching script interpreter paths in /nix/store/rwbvp8rxgmzhr1m589j0b8jwky4sy5pg-transmission-2.92
/nix/store/rwbvp8rxgmzhr1m589j0b8jwky4sy5pg-transmission-2.92
There was a problem hiding this comment.
Success for system: aarch64-linux
shrinking /nix/store/q12jdqjlf9hmwkafw1h3vyrnw0z8bs6s-transmission-2.92/bin/transmission-daemon
shrinking /nix/store/q12jdqjlf9hmwkafw1h3vyrnw0z8bs6s-transmission-2.92/bin/transmission-show
shrinking /nix/store/q12jdqjlf9hmwkafw1h3vyrnw0z8bs6s-transmission-2.92/bin/transmission-edit
shrinking /nix/store/q12jdqjlf9hmwkafw1h3vyrnw0z8bs6s-transmission-2.92/bin/transmission-create
gzipping man pages under /nix/store/q12jdqjlf9hmwkafw1h3vyrnw0z8bs6s-transmission-2.92/share/man/
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/q12jdqjlf9hmwkafw1h3vyrnw0z8bs6s-transmission-2.92/bin
patching script interpreter paths in /nix/store/q12jdqjlf9hmwkafw1h3vyrnw0z8bs6s-transmission-2.92
checking for references to /build in /nix/store/q12jdqjlf9hmwkafw1h3vyrnw0z8bs6s-transmission-2.92...
/nix/store/q12jdqjlf9hmwkafw1h3vyrnw0z8bs6s-transmission-2.92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
For further details see [1] & [2].
[1] transmission/transmission#468
[2] http://www.openwall.com/lists/oss-security/2018/01/12/1
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)