transmission: fix RCE via dns rebinding attach #33874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For further details see [1] & [2]. [1] transmission/transmission#468 [2] http://www.openwall.com/lists/oss-security/2018/01/12/1 (cherry picked from commit 50f48fc)
|
@GrahamcOfBorg test bittorrent |
There was a problem hiding this comment.
Failure for system: x86_64-linux
killing client2 (pid 144)
killing tracker (pid 155)
killing client1 (pid 165)
killing router (pid 177)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-bittorrent.drv-0/vde1.ctl': Directory not empty
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-bittorrent.drv-0/vde2.ctl': Directory not empty
builder for ‘/nix/store/f3bv7k4advq51x4zpi168gx53za13mw2-vm-test-run-bittorrent.drv’ failed with exit code 4
error: build of ‘/nix/store/f3bv7k4advq51x4zpi168gx53za13mw2-vm-test-run-bittorrent.drv’ failed
|
@GrahamcOfBorg build transmission |
There was a problem hiding this comment.
Success for system: x86_64-darwin
make[2]: Entering directory '/private/tmp/nix-build-transmission-2.92.drv-0/transmission-2.92'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-transmission-2.92.drv-0/transmission-2.92'
make[1]: Leaving directory '/private/tmp/nix-build-transmission-2.92.drv-0/transmission-2.92'
post-installation fixup
gzipping man pages under /nix/store/v5apahijqm42raxiinhgbh8133f8vxnf-transmission-2.92/share/man/
stripping (with flags -S) in /nix/store/v5apahijqm42raxiinhgbh8133f8vxnf-transmission-2.92/bin
patching script interpreter paths in /nix/store/v5apahijqm42raxiinhgbh8133f8vxnf-transmission-2.92
/nix/store/v5apahijqm42raxiinhgbh8133f8vxnf-transmission-2.92
There was a problem hiding this comment.
Success for system: x86_64-linux
shrinking /nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92/bin/transmission-show
shrinking /nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92/bin/transmission-daemon
shrinking /nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92/bin/transmission-edit
shrinking /nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92/bin/transmission-create
shrinking /nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92/bin/transmission-cli
gzipping man pages under /nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92/share/man/
stripping (with flags -S) in /nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92/bin
patching script interpreter paths in /nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92
checking for references to /tmp/nix-build-transmission-2.92.drv-0 in /nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92...
/nix/store/wwr3c44vxhsyrkddjdrx5r0cqhia3fgk-transmission-2.92
There was a problem hiding this comment.
Success for system: aarch64-linux
shrinking /nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92/bin/transmission-remote
shrinking /nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92/bin/transmission-daemon
shrinking /nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92/bin/transmission-show
shrinking /nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92/bin/transmission-edit
shrinking /nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92/bin/transmission-create
gzipping man pages under /nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92/share/man/
stripping (with flags -S) in /nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92/bin
patching script interpreter paths in /nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92
checking for references to /build in /nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92...
/nix/store/qsd39067d0mx4qsb0vczbvj2ax19kqzq-transmission-2.92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
For further details see [1] & [2].
[1] transmission/transmission#468
[2] http://www.openwall.com/lists/oss-security/2018/01/12/1
(cherry picked from commit 50f48fc)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)