Switch redis cache and brainzutils.cache (GCI17) #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis.Redis.setex() changed to brainzutils.cache.set()
Get user count using brainzutils.cache instead of redis cache
ghost
reviewed
Jan 14, 2018
There was a problem hiding this comment.
It would be useful to squash these commits into one commit, or into meaningful chunks as needed. To do this, run an interactive rebase from the head of metabrainz/master - git rebase -i 3272540 and see the help text that shows up. You'll have to git force --push to this branch after that for this to work.
paramsingh
requested changes
Jan 14, 2018
paramsingh
reviewed
Jan 14, 2018
listenbrainz/webserver/__init__.py
Outdated
| # Cache | ||
| if 'REDIS_HOST' in app.config and\ | ||
| 'REDIS_PORT' in app.config and\ | ||
| 'REDIS_NAMESPACE' in app.config and: |
There was a problem hiding this comment.
Problem seems to be the extra and here
|
Do keep in mind git commit message guidelines as well. 0581441's commit message would be better stated as |
|
Okay, I will keep it in mind, thank you |
Add key "REDIS_NAMESPACE" with value "LB", LB = ListenBrainz
Change test by setting data into brainzutils.cache instead of redis to test redis_listenstore's function get_playing_now() where used brainzutils.cache.get() instead of self.redis.get()
|
Closing this in favor of #333 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Solution
Action