Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mendeley: Re-link with qt 5.9 #33864

Merged
merged 1 commit into from Jan 15, 2018
Merged

mendeley: Re-link with qt 5.9 #33864

merged 1 commit into from Jan 15, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jan 14, 2018 •
edited

Motivation for this change

See #33798

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

As the application requires registration I have only tried to start it and it works.

cc @dtzWill

@adisbladis adisbladis mentioned this pull request Jan 14, 2018
Closed
25 tasks
@dtzWill
Copy link
Member

dtzWill commented Jan 14, 2018

So I previously experienced either warnings or a graphical glitch when not attempting to match the Qt version they bundled.

I just tried this and it .. looks good to me?

I checked with LD_DEBUG=libs and /proc/$pid/maps -- no Qt 5.6 usage in sight! (I was worried my environment might have it around and that's why it "worked").

Glad we can move to 5.9, thanks for the PR!

@adisbladis
Copy link
Member Author

@dtzWill Thanks for testing this :)

@adisbladis adisbladis merged commit 554104e into NixOS:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @dtzWill @GrahamcOfBorg