Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goxel: init at 0.7.2 #33882

Merged
merged 1 commit into from Jan 28, 2018
Merged

goxel: init at 0.7.2 #33882

merged 1 commit into from Jan 28, 2018

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Jan 15, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tilpner
Copy link
Member Author

tilpner commented Jan 15, 2018

This is advertised to run on macOS, but I can't test it there. I'll remove ++ darwin from meta.platforms if I can't find someone to test it there.

This shouldn't be merged until it's either been tested on darwin or darwin has been removed from platforms.

@tilpner
Copy link
Member Author

tilpner commented Jan 15, 2018

I found someone to build this on darwin, but it doesn't find argp.h, even after adding gnulib to buildInputs. It's probably better for someone on darwin to fix this, I've removed the platform for now.

Ready to merge now! :)

Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execution fails for me:

./result/bin/goxel
./result/bin/goxel: relocation error: /nix/store/q3wx1gab2ysnk5nyvyyg56ana2v4r2ar-glibc-2.24/lib/libpthread.so.0: symbol __libc_dl_error_tsd, version GLIBC_PRIVATE not defined in file libc.so.6 with link time reference


stdenv.mkDerivation rec {
name = "goxel-${version}";
version = "v0.7.2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version in the package name must start with a digit.

@tilpner
Copy link
Member Author

tilpner commented Jan 16, 2018

@nlewo I don't know how to reproduce or fix that. Did you do something like in #23203? Does something change when you add glibc to buildInputs?

@nlewo
Copy link
Member

nlewo commented Jan 16, 2018

@tilpner Sorry, that's my bad.
The LD_PRELOAD_PATH is set but I don't know why it is set!

echo $LD_LIBRARY_PATH 
/run/opengl-driver/lib:/run/opengl-driver-32/lib

Anyway, it works for me.
LGTM.

@adisbladis
Copy link
Member

@GrahamcOfBorg build goxel

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘goxel-0.7.2’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/graphics/goxel/default.nix:27 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.33882

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/4rbkynk3ljl0l3pvf10llmdhhwgvg53d-goxel-0.7.2/bin/goxel
shrinking RPATHs of ELF executables and libraries in /nix/store/4rbkynk3ljl0l3pvf10llmdhhwgvg53d-goxel-0.7.2
shrinking /nix/store/4rbkynk3ljl0l3pvf10llmdhhwgvg53d-goxel-0.7.2/bin/.goxel-wrapped
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4rbkynk3ljl0l3pvf10llmdhhwgvg53d-goxel-0.7.2/bin 
patching script interpreter paths in /nix/store/4rbkynk3ljl0l3pvf10llmdhhwgvg53d-goxel-0.7.2
checking for references to /tmp/nix-build-goxel-0.7.2.drv-0 in /nix/store/4rbkynk3ljl0l3pvf10llmdhhwgvg53d-goxel-0.7.2...
/nix/store/4rbkynk3ljl0l3pvf10llmdhhwgvg53d-goxel-0.7.2

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.33882

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/qpi7fwyps1998c6hcw0g8gff4f55x39m-goxel-0.7.2/bin/goxel
shrinking RPATHs of ELF executables and libraries in /nix/store/qpi7fwyps1998c6hcw0g8gff4f55x39m-goxel-0.7.2
shrinking /nix/store/qpi7fwyps1998c6hcw0g8gff4f55x39m-goxel-0.7.2/bin/.goxel-wrapped
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qpi7fwyps1998c6hcw0g8gff4f55x39m-goxel-0.7.2/bin
patching script interpreter paths in /nix/store/qpi7fwyps1998c6hcw0g8gff4f55x39m-goxel-0.7.2
checking for references to /build in /nix/store/qpi7fwyps1998c6hcw0g8gff4f55x39m-goxel-0.7.2...
/nix/store/qpi7fwyps1998c6hcw0g8gff4f55x39m-goxel-0.7.2

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.33882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants