Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spectre-meltdown-checker: 0.29 -> 0.31 #33869

Merged
merged 1 commit into from Jan 14, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

The patch to find NixOS kernel is now merged upstream.

Since the author explicitly specified /bin/echo, I did him a favour and use coreutils' echo as well 😄

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member Author

cc @adisbladis @andir

@andir
Copy link
Member

andir commented Jan 14, 2018

@GrahamcOfBorg build spectre-meltdown-checker

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘spectre-meltdown-checker-0.31’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/tools/security/spectre-meltdown-checker/default.nix:28 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/05jm8rdxg9hq6n529d8jw7bd1q4wdc5s-spectre-meltdown-checker-0.31
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/05jm8rdxg9hq6n529d8jw7bd1q4wdc5s-spectre-meltdown-checker-0.31/lib  /nix/store/05jm8rdxg9hq6n529d8jw7bd1q4wdc5s-spectre-meltdown-checker-0.31/bin 
patching script interpreter paths in /nix/store/05jm8rdxg9hq6n529d8jw7bd1q4wdc5s-spectre-meltdown-checker-0.31
/nix/store/05jm8rdxg9hq6n529d8jw7bd1q4wdc5s-spectre-meltdown-checker-0.31/lib/spectre-meltdown-checker.sh: interpreter directive changed from " /bin/sh" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-spectre-meltdown-checker-0.31.drv-0 in /nix/store/05jm8rdxg9hq6n529d8jw7bd1q4wdc5s-spectre-meltdown-checker-0.31...
/nix/store/05jm8rdxg9hq6n529d8jw7bd1q4wdc5s-spectre-meltdown-checker-0.31

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/babgh7f2f30jfraicxknx112nk3xx592-spectre-meltdown-checker-0.31
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/babgh7f2f30jfraicxknx112nk3xx592-spectre-meltdown-checker-0.31/lib  /nix/store/babgh7f2f30jfraicxknx112nk3xx592-spectre-meltdown-checker-0.31/bin
patching script interpreter paths in /nix/store/babgh7f2f30jfraicxknx112nk3xx592-spectre-meltdown-checker-0.31
/nix/store/babgh7f2f30jfraicxknx112nk3xx592-spectre-meltdown-checker-0.31/lib/spectre-meltdown-checker.sh: interpreter directive changed from " /bin/sh" to "/nix/store/b2rfm1s05ria7d00r4p9r7f5lg7llazi-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/babgh7f2f30jfraicxknx112nk3xx592-spectre-meltdown-checker-0.31...
/nix/store/babgh7f2f30jfraicxknx112nk3xx592-spectre-meltdown-checker-0.31

@andir
Copy link
Member

andir commented Jan 14, 2018

Thanks @dotlambda!

@andir andir merged commit 890c804 into NixOS:master Jan 14, 2018
@dotlambda dotlambda deleted the spectre-meltdown-checker branch January 14, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants