-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.fritzconnection: init at 0.6.5 #33878
Conversation
Whithout the
But as it is, building and testing works fine on both, Python 2 and 3. |
Interesting. There is a package called Packages and modules in the current folder take precedence over To conclude, upstream likely does not test against Python 3. |
description = "Python-Tool to communicate with the AVM FritzBox using the TR-064 protocol"; | ||
homepage = https://bitbucket.org/kbr/fritzconnection; | ||
license = licenses.mit; | ||
platforms = platforms.unix; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for setting this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular. Does it hurt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is set correctly by buildPython*
already. It should only be set in case a certain specific platform is not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know :)
I've removed it
Thanks for the explanation, @FRidh. I'll open an upstream issue asap. |
See https://bitbucket.org/kbr/fritzconnection/pull-requests/13. |
f15fa28
to
3064015
Compare
Motivation for this change
Does anyone have an idea why the
substituteInPlace
is only necessary for Python 3?Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)